Ostracon, a consensus algorithm, is forked from Tendermint Core. We have added VRF to Tendermint BFT. It adds randomness to PoS Validator elections and improves security.
Hi, I'm looking at the ostracon code and came across the annotation that I found awkward.
I found that the same comment is described not only in ostracon but also in cometBFT, so I changed cometBFT first and my proposal was approved.
Here is the related link: https://github.com/cometbft/cometbft/pull/1056
In types/params.go, the value of BlockPartSizeBytes is 65536 (about 64kB).
In the function func NewPartSetFromData(data []byte, partSize uint32) *PartSet in types/part_set.go, the function uses the parameter partSize which is the value of BlockPartSizeBytes.
However, the annotation says it's 4kB, so I'm doing a pull request to fix it.
Hi, I'm looking at the ostracon code and came across the annotation that I found awkward. I found that the same comment is described not only in ostracon but also in cometBFT, so I changed cometBFT first and my proposal was approved. Here is the related link: https://github.com/cometbft/cometbft/pull/1056
In
types/params.go
, the value of BlockPartSizeBytes is 65536 (about 64kB). In the functionfunc NewPartSetFromData(data []byte, partSize uint32) *PartSet
intypes/part_set.go
, the function uses the parameterpartSize
which is the value of BlockPartSizeBytes. However, the annotation says it's 4kB, so I'm doing a pull request to fix it.