search

Finschia / ostracon

Ostracon, a consensus algorithm, is forked from Tendermint Core. We have added VRF to Tendermint BFT. It adds randomness to PoS Validator elections and improves security.
Apache License 2.0
70 stars 28 forks source link

Change pathlib version from v1.0.0 to v0.15.0 #662

Closed Mdaiki0730 closed 1 year ago

Mdaiki0730 commented 1 year ago

Description

github.com/chigopher/pathlib@v1.0.0 does not exist, so change the dependency version to the appropriate one.

Closes: #661

codecov[bot] commented 1 year ago

Codecov Report

Merging #662 (f7beb95) into main (5a2453e) will decrease coverage by 0.08%. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #662 +/- ## ========================================== - Coverage 66.16% 66.08% -0.08% ========================================== Files 275 275 Lines 36930 36930 ========================================== - Hits 24433 24404 -29 - Misses 10733 10761 +28 - Partials 1764 1765 +1 ``` [see 13 files with indirect coverage changes](https://app.codecov.io/gh/Finschia/ostracon/pull/662/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)
tnasu commented 1 year ago

If pathlib is had a dependency by the mockery, I think using the replace directive in the go.mod for excluding the dependency of mockery.

Here are recent updates of mockery. They may be going to upgrade a lot of things.

Mdaiki0730 commented 1 year ago

Does excluding a dependency mean replacing it with a specific version?

ulbqb commented 1 year ago

https://github.com/chigopher/pathlib/tags I think this fix is better because pathlib@v1.0.0 doesn't exist.