Closed tkxkd0159 closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 66.64%. Comparing base (
2aa7d4c
) to head (489777b
). Report is 2 commits behind head on main.
https://github.com/tendermint/tendermint/blob/main/crypto/encoding/codec.go Is it possible to use tendermint package in your situation? It looks like codec file should be removed in Ostracon because of duplication.
https://github.com/tendermint/tendermint/blob/main/crypto/encoding/codec.go Is it possible to use tendermint package in your situation? It looks like codec file should be removed in Ostracon because of duplication.
Yeah I think it's possible. But I have heard that our repo will be converted with cometbft soon. So I just tried to not change as much as possible. Is it better to replace with tendermint now? @ulbqb
So I just tried to not change as much as possible.
That’s make sense.
Description
tendermint-rs
. It renames fields astendermint.crypto.*
viaserde
for PublicKey. (ref)finschia-sdk
.sdk
registers their amino types here.Closes: #XXX