Closed 170210 closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 66.53%. Comparing base (
fc54d22
) to head (4a2f67b
). Report is 3 commits behind head on main.
It looks like empty proofs are admitted intentionally. Would you research this?
Please add following contents to description:
Description
This PR added an error handle in proof size check when the VRF proof is empty.
Previously, we allowed the proof hash to be 0 in Validateproof because there was no proof required when verifying Genesis block's information. However, since there is no Genesis block, the proof hash should not be zero in general verification.
I tested it with finschia-sdk, and there is no problem when this handling was added.
related #510