Closed 170210 closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 66.54%. Comparing base (
fc54d22
) to head (4ca0270
). Report is 3 commits behind head on main.:exclamation: Current head 4ca0270 differs from pull request most recent head 01814c0. Consider uploading reports for the commit 01814c0 to get more accurate results
Is it ok not to change parsing process although you change toml format?
And old processes are left.
Is it ok not to change parsing process although you change toml format?
https://github.com/Finschia/ostracon/blob/ae67c39c8a79827fc0aeeddf86f64bdbf193cbf4/privval/internal/ip_filter.go#L29-L31 I checked currently main branch and #707, this function hasn't been used yet (only used in test), so I think we just need to delete it.
Is it ok not to change parsing process although you change toml format?
Is it ok not to change parsing process although you change toml format?
@ulbqb I think it is ok because after parsing with viper, it is read in as an array. https://github.com/Finschia/ostracon/blob/ae67c39c8a79827fc0aeeddf86f64bdbf193cbf4/config/config.go#L253
I checked currently main branch and https://github.com/Finschia/ostracon/pull/707, this function hasn't been used yet (only used in test), so I think we just need to delete it.
Sorry, this is for Stringer interface so needed.
Description
This PR fix incompatible type of
priv_validator_raddrs
in TOML ThePrivValidatorRemoteAddresses
was defined as string array, while thepriv_validator_raddrs
was of a string type rather than a slice type, which creates a mismatch with the structure of the configuration after parsing the toml file. Related #692 & #707