Finschia / ostracon

Ostracon, a consensus algorithm, is forked from Tendermint Core. We have added VRF to Tendermint BFT. It adds randomness to PoS Validator elections and improves security.
Apache License 2.0
69 stars 28 forks source link

fix: add string trim for PrivValidatorListenAddr string #768

Closed jaeseung-bae closed 8 months ago

jaeseung-bae commented 8 months ago

Description

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.54%. Comparing base (1279868) to head (3d05d06). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #768 +/- ## ========================================== + Coverage 66.52% 66.54% +0.01% ========================================== Files 285 285 Lines 37917 37917 ========================================== + Hits 25224 25231 +7 + Misses 10887 10885 -2 + Partials 1806 1801 -5 ``` | [Files](https://app.codecov.io/gh/Finschia/ostracon/pull/768?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [cmd/ostracon/commands/show\_validator.go](https://app.codecov.io/gh/Finschia/ostracon/pull/768?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-Y21kL29zdHJhY29uL2NvbW1hbmRzL3Nob3dfdmFsaWRhdG9yLmdv) | `72.72% <100.00%> (ø)` | | | [node/node.go](https://app.codecov.io/gh/Finschia/ostracon/pull/768?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-bm9kZS9ub2RlLmdv) | `61.49% <100.00%> (ø)` | | ... and [11 files with indirect coverage changes](https://app.codecov.io/gh/Finschia/ostracon/pull/768/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)
ulbqb commented 8 months ago

https://github.com/Finschia/ostracon/blob/df661e931c14c6ec2332a931ce6a1092d0f8d812/cmd/ostracon/commands/show_validator.go#L29

Should this be fixed too?

ulbqb commented 8 months ago

Please add issue detail.

jaeseung-bae commented 8 months ago

https://github.com/Finschia/ostracon/blob/df661e931c14c6ec2332a931ce6a1092d0f8d812/cmd/ostracon/commands/show_validator.go#L29

Should this be fixed too?

It has been fixed(3d05d06bdb76f5b0e278930564f1a60be4060cec)