search

Flode-Labs / vid2densepose

Convert your videos to densepose and use it on MagicAnimate
MIT License
957 stars 122 forks source link

Fix the "Run the script" example #13

Closed Jamim closed 6 months ago

Jamim commented 6 months ago

Hello,

There is an issue with the Run the script example in the Usage Guide. An excessive indentation leads to a wrongly rendered misleading code.

Best regards!

Jamim commented 6 months ago

Hi @tadeodonegana, Is there any reason to just close this PR? 🤔 The Usage Guide still looks like this: Screenshot 2023-12-10 at 04-49-40 Flode-Labs_vid2densepose Convert your videos to densepose and use it on MagicAnimate

cc @igorriti

tadeodonegana commented 6 months ago

Hi @tadeodonegana, Is there any reason to just close this PR? 🤔 The Usage Guide still looks like this: Screenshot 2023-12-10 at 04-49-40 Flode-Labs_vid2densepose Convert your videos to densepose and use it on MagicAnimate

cc @igorriti

Please check 8005ab2. Problem was fixed.

Jamim commented 6 months ago

Wait a minute. Let's repeat what you've did.

  1. Silently closed this PR
  2. Added changes from the PR into your own commit mixing them with completely unrelated changes, with no Co-authored-by in a commit message
  3. Submitted a new mixed PR: #17
  4. Merged your own PR

And I see it's not a first time. The same situation was here: #5 (https://github.com/Flode-Labs/vid2densepose/commit/7358842af3af12a2799a15a0dd30ef2f119191b1)

I completely realize my changes were trivial, but your approach on handling pull requests is surprisingly disrespectful. You might think it's fine to do things like this, but it's definitely not.

tadeodonegana commented 6 months ago

Wait a minute. Let's repeat what you've did.

  1. Silently closed this PR
  2. Added changes from the PR into your own commit mixing them with completely unrelated changes, with no Co-authored-by in a commit message
  3. Submitted a new mixed PR: Ignore .DS_Store and Update README.md #17
  4. Merged your own PR

And I see it's not a first time. The same situation was here: #5 (7358842)

I completely realize my changes were trivial, but your approach on handling pull requests is surprisingly disrespectful. You might think it's fine to do things like this, but it's definitely not.

My apologies if you felt disrespected.

Feel free to open other pull requests if you want to collaborate, and we will review it like we do with all of them.

Also thank you for the comments, i will take them in count.

Have a good day.