Diamond Waterproof Pipe GUI crash

[viliml]

---- Minecraft Crash Report ---- // Why did you do that?

Time: 26.04.13. 20:39 Description: Rendering screen

java.lang.NullPointerException at net.minecraft.client.gui.Gui.func_94065_a(SourceFile:115) at abo.pipes.liquids.gui.GuiPipeLiquidsDiamond$LiquidSlot.drawSprite(GuiPipeLiquidsDiamond.java:73) at buildcraft.core.gui.GuiAdvancedInterface.drawBackgroundSlots(GuiAdvancedInterface.java:135) at abo.pipes.liquids.gui.GuiPipeLiquidsDiamond.func_74185_a(GuiPipeLiquidsDiamond.java:124) at net.minecraft.client.gui.inventory.GuiContainer.func_73863_a(ayl.java:80) at net.minecraft.client.renderer.EntityRenderer.func_78480_b(EntityRenderer.java:1155) at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:870) at net.minecraft.client.Minecraft.run(Minecraft.java:759) at java.lang.Thread.run(Unknown Source)

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head -- Stacktrace: at net.minecraft.client.gui.Gui.func_94065_a(SourceFile:115) at abo.pipes.liquids.gui.GuiPipeLiquidsDiamond$LiquidSlot.drawSprite(GuiPipeLiquidsDiamond.java:73) at buildcraft.core.gui.GuiAdvancedInterface.drawBackgroundSlots(GuiAdvancedInterface.java:135) at abo.pipes.liquids.gui.GuiPipeLiquidsDiamond.func_74185_a(GuiPipeLiquidsDiamond.java:124) at net.minecraft.client.gui.inventory.GuiContainer.func_73863_a(ayl.java:80)

-- Screen render details -- Details: Screen name: abo.pipes.liquids.gui.GuiPipeLiquidsDiamond Mouse location: Scaled: (213, 119). Absolute: (427, 240) Screen size: Scaled: (427, 240). Absolute: (854, 480). Scale factor of 2

-- Affected level -- Details: Level name: MpServer All players: 1 total; [EntityClientPlayerMP['Offline'/277, l='MpServer', x=224,72, y=70,62, z=159,26]] Chunk stats: MultiplayerChunkCache: 441 Level seed: 0 Level generator: ID 00 - default, ver 1. Features enabled: false Level generator options: Level spawn location: World: (-4,64,220), Chunk: (at 12,4,12 in -1,13; contains blocks -16,0,208 to -1,255,223), Region: (-1,0; contains chunks -32,0 to -1,31, blocks -512,0,0 to -1,255,511) Level time: 6519 game time, 7520 day time Level dimension: 0 Level storage version: 0x00000 - Unknown? Level weather: Rain time: 0 (now: false), thunder time: 0 (now: false) Level game mode: Game mode: creative (ID 1). Hardcore: false. Cheats: false Forced entities: 64 total; [EntityClientPlayerMP['Offline'/277, l='MpServer', x=224,72, y=70,62, z=159,26], EntityBat['Bat'/1358, l='MpServer', x=274,46, y=55,91, z=109,02], EntitySheep['Sheep'/258, l='MpServer', x=169,91, y=63,00, z=184,94], EntitySheep['Sheep'/259, l='MpServer', x=171,53, y=64,00, z=188,53], EntityZombie['Zombie'/257, l='MpServer', x=160,50, y=21,00, z=178,50], EntityItem['item.tile.flower'/262, l='MpServer', x=160,78, y=63,13, z=197,63], EntitySheep['Sheep'/260, l='MpServer', x=170,41, y=63,00, z=187,53], EntitySheep['Sheep'/261, l='MpServer', x=174,75, y=63,00, z=181,47], EntityCreeper['Creeper'/266, l='MpServer', x=188,69, y=17,00, z=230,09], EntityBat['Bat'/267, l='MpServer', x=186,72, y=46,40, z=206,71], EntityBlock['unknown'/442, l='MpServer', x=224,25, y=68,00, z=160,25], EntityBat['Bat'/309, l='MpServer', x=224,81, y=24,26, z=208,25], EntitySheep['Sheep'/308, l='MpServer', x=215,91, y=69,00, z=89,97], EntityBlock['unknown'/446, l='MpServer', x=224,25, y=67,00, z=160,25], EntitySpider['Spider'/311, l='MpServer', x=217,28, y=17,89, z=212,81], EntityBat['Bat'/310, l='MpServer', x=220,91, y=25,88, z=206,25], EntityZombie['Zombie'/312, l='MpServer', x=214,06, y=17,00, z=229,31], EntityCreeper['Creeper'/295, l='MpServer', x=195,50, y=17,00, z=223,50], EntityBat['Bat'/296, l='MpServer', x=200,49, y=44,00, z=220,20], EntitySkeleton['Skeleton'/297, l='MpServer', x=195,50, y=17,00, z=226,50], EntityBat['Bat'/298, l='MpServer', x=196,25, y=44,83, z=234,48], EntityCreeper['Creeper'/299, l='MpServer', x=194,50, y=45,00, z=233,50], EntityCreeper['Creeper'/343, l='MpServer', x=275,00, y=40,00, z=135,59], EntitySpider['Spider'/342, l='MpServer', x=264,63, y=41,00, z=136,25], EntitySkeleton['Skeleton'/341, l='MpServer', x=264,63, y=41,17, z=136,25], EntityZombie['Zombie'/340, l='MpServer', x=267,50, y=40,00, z=129,50], EntityZombie['Zombie'/339, l='MpServer', x=271,34, y=39,00, z=135,66], EntityPig['Pig'/338, l='MpServer', x=268,94, y=68,00, z=118,06], EntityCow['Cow'/337, l='MpServer', x=258,41, y=86,00, z=89,63], EntityCow['Cow'/336, l='MpServer', x=265,84, y=87,00, z=82,50], EntityPig['Pig'/351, l='MpServer', x=272,22, y=66,00, z=119,78], EntitySkeleton['Skeleton'/350, l='MpServer', x=272,50, y=70,00, z=86,50], EntityCreeper['Creeper'/347, l='MpServer', x=264,63, y=36,00, z=213,22], EntityCreeper['Creeper'/346, l='MpServer', x=265,16, y=36,00, z=214,69], EntityCreeper['Creeper'/345, l='MpServer', x=265,75, y=41,00, z=137,69], EntityCreeper['Creeper'/344, l='MpServer', x=270,50, y=39,00, z=134,50], EntityCow['Cow'/334, l='MpServer', x=255,16, y=86,00, z=81,81], EntityCow['Cow'/335, l='MpServer', x=264,38, y=88,00, z=81,38], EntityCow['Cow'/332, l='MpServer', x=256,53, y=84,00, z=91,47], EntityCow['Cow'/333, l='MpServer', x=264,50, y=87,00, z=85,50], EntityCow['Cow'/330, l='MpServer', x=260,50, y=84,00, z=94,50], EntityCow['Cow'/331, l='MpServer', x=263,50, y=84,00, z=95,50], EntitySheep['Sheep'/238, l='MpServer', x=150,97, y=63,00, z=113,31], EntityBat['Bat'/254, l='MpServer', x=146,07, y=38,90, z=214,56], EntitySkeleton['Skeleton'/356, l='MpServer', x=285,88, y=29,00, z=162,38], EntitySkeleton['Skeleton'/252, l='MpServer', x=158,50, y=48,00, z=220,50], EntitySkeleton['Skeleton'/253, l='MpServer', x=153,31, y=48,00, z=221,16], EntityPig['Pig'/352, l='MpServer', x=274,50, y=65,00, z=118,50], EntityZombie['Zombie'/250, l='MpServer', x=157,50, y=49,00, z=194,50], EntityPig['Pig'/353, l='MpServer', x=273,81, y=66,00, z=118,19], EntityZombie['Zombie'/251, l='MpServer', x=145,66, y=35,00, z=210,66], EntitySkeleton['Skeleton'/354, l='MpServer', x=275,69, y=40,00, z=134,41], EntitySpider['Spider'/248, l='MpServer', x=164,03, y=50,00, z=200,13], EntityCreeper['Creeper'/355, l='MpServer', x=273,34, y=39,00, z=131,94], EntitySpider['Spider'/249, l='MpServer', x=156,59, y=49,00, z=203,06], EntitySkeleton['Skeleton'/364, l='MpServer', x=300,50, y=48,00, z=227,50], EntitySheep['Sheep'/246, l='MpServer', x=148,47, y=63,00, z=195,50], EntitySheep['Sheep'/247, l='MpServer', x=149,53, y=63,00, z=195,50], EntitySheep['Sheep'/244, l='MpServer', x=150,53, y=63,00, z=192,47], EntitySheep['Sheep'/245, l='MpServer', x=149,47, y=63,00, z=193,53], EntityEnderman['Enderman'/242, l='MpServer', x=151,44, y=12,00, z=143,91], EntityZombie['Zombie'/243, l='MpServer', x=159,50, y=21,00, z=166,50], EntityBat['Bat'/1212, l='MpServer', x=156,57, y=14,90, z=146,52], EntitySheep['Sheep'/240, l='MpServer', x=144,50, y=64,00, z=116,06]] Retry entities: 0 total; [] Stacktrace: at net.minecraft.client.multiplayer.WorldClient.func_72914_a(WorldClient.java:441) at net.minecraft.client.Minecraft.func_71396_d(Minecraft.java:2413) at net.minecraft.client.Minecraft.run(Minecraft.java:775) at java.lang.Thread.run(Unknown Source)

-- System Details -- Details: Minecraft Version: 1.5.1 Operating System: Windows 7 (x86) version 6.1 Java Version: 1.7.0_21, Oracle Corporation Java VM Version: Java HotSpot(TM) Client VM (mixed mode), Oracle Corporation Memory: 262742464 bytes (250 MB) / 519110656 bytes (495 MB) up to 1037959168 bytes (989 MB) JVM Flags: 2 total; -Xms512m -Xmx1024m AABB Pool Size: 11323 (634088 bytes; 0 MB) allocated, 3340 (187040 bytes; 0 MB) used Suspicious classes: FML and Forge are installed IntCache: cache: 0, tcache: 0, allocated: 3, tallocated: 63 FML: MCP v7.44 FML v5.1.43.673 Minecraft Forge 7.7.1.673 Optifine OptiFine_1.5.1_HD_U_D1 33 mods loaded, 33 mods active mcp{7.44} Minecraft Coder Pack Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available FML{5.1.43.673} Forge Mod Loader Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available Forge{7.7.1.673} Minecraft Forge Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available CoFHCore{1.5.1.1} CoFH Core Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available mod_TooManyItems{1.5.1 2012-03-23} mod_TooManyItems Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available CoFHNetwork{1.5.1.1} CoFHNetwork Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available CoFHWorld{1.5.1.1} CoFHWorld Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available BuildCraft|Core{jenkins-Buildcraft-114.114} BuildCraft Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available BuildCraft|Builders{jenkins-Buildcraft-114.114} BC Builders Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available BuildCraft|Energy{jenkins-Buildcraft-114.114} BC Energy Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available BuildCraft|Factory{jenkins-Buildcraft-114.114} BC Factory Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available BuildCraft|Transport{jenkins-Buildcraft-114.114} BC Transport Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available BuildCraft|Silicon{jenkins-Buildcraft-114.114} BC Silicon Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available Additional-Buildcraft-Objects{1.0.3} Additional Buildcraft Objects Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available ComputerCraft{1.52} ComputerCraft Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available CCTurtle{1.52} ComputerCraft Turtles Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available craftguide{1.5.2} CraftGuide Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available Forestry{2.1.2.31} Forestry for Minecraft Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available OmniTools{3.1.1.0} OmniTools Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available ThermalExpansion{2.3.2.0} Thermal Expansion Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available IC2{1.115.304-lf} IndustrialCraft 2 Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available diamondbuckets{0.97} Diamond Buckets Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available EE3{pre1g (build 4)} Equivalent Exchange 3 Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available IronChest{5.2.2.336} Iron Chest Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available LogisticsPipes|Main{0.7.2.${env.BUILD_NUMBER}} Logistics Pipes Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available Ideas{1} [Ideas](Metallurgy 3.0.0.0.9.4.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available Metallurgy3Core{3.0.0.0.9.4} [Metallurgy 3 Core](Metallurgy 3.0.0.0.9.4.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available Metallurgy3Base{3.0.0.0.9.4} [Metallurgy 3 Base](Metallurgy 3.0.0.0.9.4.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available Metallurgy3Machines{3.0.0.0.9.4} [Metallurgy 3 Machines](Metallurgy 3.0.0.0.9.4.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available Metallurgy3Vanilla{3.0.0.0.9.4} [Metallurgy 3 Vanilla](Metallurgy 3.0.0.0.9.4.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available RopesPlus{1.3.9} Ropes+ Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available mod_SmartMoving{13.7} [Smart Moving](Smart Moving Universal for ModLoader or Minecraft Forge or MCPC+.zip) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available mod_SmartRender{1.1} [Smart Render](Smart Moving Universal for ModLoader or Minecraft Forge or MCPC+.zip) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available LWJGL: 2.4.2 OpenGL: Intel(R) G45/G43 Express Chipset GL version 2.1.0 - Build 8.15.10.2226, Intel Is Modded: Definitely; Client brand changed to 'fml,forge' Type: Client (map_client.txt) Texture Pack: faithful_animated32pack.zip Profiler Position: N/A (disabled) Vec3 Pool Size: 1747 (97832 bytes; 0 MB) allocated, 2 (112 bytes; 0 MB) used

As soon as I right-clicked on the pipe.

[Flow86]

Hi, do you have a liquid not providing a proper image? I'll check the exact problem tomorrow.

[viliml]

I don't think so... There was a problem with forestry's crushed ice, but I think it was fixed... Why don't you just implement the vanilla BC diamond pipe GUI, so that when that ghost slot is clicked with an item, the slot is filled with the LiquidContainerRegistry.getLiquidFromFilledItem()?

[viliml]

Also, that happened befoer the GUI had any liquids! I just place the pipe, right-click and BOOM! Crash!

[viliml]

Oh dear... Looking at your code... Copying LiquidDictionary.getLiquids()...

[Flow86]

then try to iterate over a Map including one special item. do it yourself better and send me a push.

The problem isnt an ABO one - one liquid in the liquiddictionary doesnt return an icon. I add a null-check to avoid the crash, but simply one mod doesnt properly register its liquid icons (see e51ea32c540abe31edbb4f4f3564ee635c8977a9)

[viliml]

Yes, the 2 possible issues are with crushed ice and biofuel. I got crashes with ice, and other people with biofuel. Forestry betas are realy just betas! But, if you say that your last commit fixes it, I'll close the issue! You could have closed it yourselfin the commit message too! https://github.com/blog/1386-closing-issues-via-commit-messages

[Flow86]

I know that I could close it via commit message - I simply forgot to mention it in it ;-)