search

Flow86 / Additional-Buildcraft-Objects-Mod

This mod adds additional Pipes and Items to Buildcraft
http://www.minecraftforum.net/index.php?app=forums&module=forums&section=findpost&pid=8920844
44 stars 21 forks source link

LiquidHopper #59

Open rubensworks opened 10 years ago

rubensworks commented 10 years ago

I've implemented the LiquidHopper as mentioned in https://github.com/BuildCraft/BuildCraft/issues/1291 and https://github.com/BuildCraft/BuildCraft/pull/1310 in the BuildCraft repo. It seems like the main BuildCraft devs didn't like it after all, so if you want you're welcome to add it to ADO.

The code for it can be found in my fork of BuildCraft: https://github.com/rubensworks/BuildCraft/commit/80ab099b9bcf04d9213e1e5ae7184564a82412a7

I don't know if you would need anything else?

Flow86 commented 10 years ago

Sounds good to add, I will do it in a few days. Too much work this week :/

nevercast commented 10 years ago

It's not that they didn't necessarily like it. You just have to discuss changes in mechanics with the devs first BEFORE submitting a PR.

rubensworks commented 10 years ago

Well, the feature request issue was open for quite a while. I also couldn't find any information on how to directly contact the main devs.

nevercast commented 10 years ago

IRC, #buildcraft, irc.esper.net. Learn to IRC :)