search

Fluorohydride / ygopro

A script engine for "yu-gi-oh!" and sample gui
GNU General Public License v2.0
1.83k stars 593 forks source link

Leadership Roles #1628

Closed Zayelion closed 7 years ago

Zayelion commented 8 years ago

So I admittedly have no idea what I am doing here but I will try my best.

Everyone that is currently working on a YGOPro variant in "some capacity" state what you do and for which variant. After that we will identify the needs of each group. From those needs we can hash out what code changes need to be done where and why.

Goals

After each person states what position and team they are on I'll add them to the following list so we have it as reference, then we can elect leaders out of each group or assign work based on that as need be

Translated with @mercury233 help:

前言：ygopro的很多修改版都增加了音效、皮肤、窗口缩放等功能，但却是相互独立的，存在明显的“重复发明轮子”现象。因此Zayelion想做点什么来改变这个情况。

首先要统计出现在参与ygopro的人，有什么能力，在做什么，在哪个修改版。然后我们确定各个团队的需求，根据这些需求得出我们需要怎样修改代码。

目标 统计多少人参与ygopro相关，以及他们重复的工作 确定现有的领导者 列出各个领域的人的共识 实现大家需要的东西，更好的服务于游戏王环境 建立某种形式的领导者团队

大家请在这里写下自己的位置和团队，我会把它们加到下面的列表里。

Variant Owners @zh99998 @SuperAndroid17 @Zayelion @Moonlightsorrow @mercury233 @Tic-Tac-Toc

Client @IceYGO @adrianojn @sidschingis

Launcher/Server @IrateGod @StormWulf @ChibiChanNya @westcoastkiwi @GuybrushThreepwoodSD @IceYGO @0mniMage @sidschingis

Scriptors @ChibiChanNya @StormWulf @HelixReactor @KoneSkirata @destdev

Quality Assurance / Testers @BlackBallista @Laughing-Luna @StormWulf @KoneSkirata @destdev @GuybrushThreepwoodSD @LordVyro

Images @ParryDox @CollateralDamage @KoneSkirata @destdev

Community Management @CollateralDamage @TheHolyTrinity @KoneSkirata @destdev @0mniMage @LordVyro

Termita commented 8 years ago

Well my role here is only one, so far I can compile the exe but not conosco language well, Iam in charge of translating the Spanish public all version ygopro Percy, and management the launcher of updates independently percyval, my contributions for you, tester and suggestions as to what my users say xD

I also know very well and handling SQL database.

Bueno mi papel aqui es solo uno,yo hasta ahora puedo compilar el exe pero no conosco bien el lenguaje,soy el encargado de traducir al publico español toda la version ygopro percy,y manejo el lanzador de actualizaciones de manera independiente a percyval,mis aportes para ustedes,tester y sugerencias en cuanto a lo que dicen mis usuarios xD.

Tambien se SQL y manejo muy bien la base de datos.

Zayelion commented 8 years ago

Themes & Resize

https://github.com/Fluorohydride/ygopro/issues/1633

Sounds & Music

https://github.com/Fluorohydride/ygopro/issues/1634

Tic-Tac-Toc commented 8 years ago

Main developper and Creator of Battle City Alpha (http://battlecityalpha.xyz/). A french YGOPro game. I use Windbot, ygosharp server, the core and the scripts of fluorohydride. My WindBot deck is on my git.

Zayelion commented 8 years ago

Code Review System

As more people start commiting code, and giving their views on things I feel there should be a buffer to make sure it does not break the significant parts of the system. ygopro-core needs unit test for each of its functions.

https://travis-ci.org/

It is confusing to people interested in the project to see repeated commits that are only fix fix fix repeatedly. Please add more information so others can follow along (even if it is not in English). Anyone that can read and understand the code, critique it actively even if you are not asked. The point of the exercise is to protect the codebase, those working on it, and those using it.

Launcher Enabling Features

These features follow the legacy of @zh99998 by enhancing the client so it can be augmented easily. These are a low priority.

Prereleased Cards

https://github.com/Fluorohydride/ygopro/issues/1631

Design Spec

Information about YGOPro's internal design on the wikia.

Documentation of the Current Lua API

Function by function explaination of what each function is exposed by the ygopro-core and ygopro-scripts/utility.lua so newcomers can learn to write cards easily.

Sorry if I come off aggressive, I've been watching and working on the project for over three years now and I just want it to continue growing! _(:з」∠)_

CloudParameters commented 8 years ago

Communications Officer and Liaison between @SalvationDevelopment and Dueling Network

Zayelion commented 8 years ago

@salix5 @VanillaSalt @Fluorohydride In regards to a test system what languages are you 3 most comfortable writing/programming in?

salix5 commented 8 years ago

I am familiar with C++, and my native language is Chinese.

Termita commented 8 years ago

alguien sabe la ip y los puertos del servidor chino de ygopot ?

ghost commented 8 years ago

Can ygopro currently support Custom Cards/alt formats like sealed or construction, Also how do you guys feel about mods to the ygopro source for other card games. Can other card games be "supported" on ygopro?

IceYGO commented 8 years ago

Can other card games be "supported" on ygopro?

Not realistically. YGOPro is just a graphical wrapper over the ocgcore library and ocgcore has nothing in common with other card games. It would require a huge amount of additional code and creating another project is just as fast.

StormWulf commented 8 years ago

Salvation made a Battle Pack 3 Sealed Play mode, but it has stopped working due to reasons that only Zayelion can explain.

Zayelion commented 8 years ago

Salvation used to support Sealed (its bugged, hence this thread, the gframe has to be normalized, and we lost the "force" feature, our team lacks strong C++ programmers and people toying around in this repo makes our efforts have to be undone anyway.), it doesnt support the exact rules of construction due to the complexity of it. I do not believe that YGOPro should be modified to support other card games because that will negatively impact everyone and result in the product being shutdown, or at the very least its quality reduced I believe this very strongly and its supported by evidence from people trying before.

My first point on this is user expectation, and I think this is important in general and every programmer here should try this before they build something. Who are you building this for, do they even wanted it? Do they need it? Will they use it?

There are so many variants because none of us can agree on the core audience of YGOPro, or honestly do not care and are being selfish for our own egos. @Loadedtothemax the type of thinking you are exploring of adding bell and whistles that are very extreme will split us more.

Its best we work on things that we all can or have already agreed on thats why we are limiting discussion to the features engineered two or three times outside this repository, or enforce stability.

Zayelion commented 8 years ago

Update on ygopro-pre-script

https://github.com/Zayelion/ygopro-pre-script/issues/2#issuecomment-169799017 waiting for it to be moved over to this user.

edit : completed. @Fluorohydride THANK YOU!

Zayelion commented 8 years ago

Moving the topic of conversation to the launchers, to the people that have commit rights to ygopro are you guys familiar with how they they work, what use case they fulfill, and why they where built? For each of the teams please provide pictures of each of the launchers along with explanations of the features.

ghost commented 8 years ago

You should go over them for reference

zh99998 commented 8 years ago

zh99998, MyCard. a launcher, service, forum, and planed deck editor, database api and more.

I did'n t contribute to ygopro upstream much more yet since i'm not good at c++.

my code is under github.com/mycard

Thanks Fluorohydride and all contributors.

Zayelion commented 8 years ago

@zh99998 https://github.com/Fluorohydride/ygopro/commit/48219da913f18a5271b6a404982dc73d99f6224e#diff-7c1b9672d7d2a0f3473a51edffae0c8d

Launchers (and our teams) would not be possible without you. We are in your debt.

Tragoedia commented 8 years ago

Tragedy, working on the site & launcher UI @SalvationDevelopment Here are the pics of the DevPro Launcher:

Login Page

Login: http://prntscr.com/a176jy Validate: http://prntscr.com/a179co Register: http://prntscr.com/a179kx Recover: http://prntscr.com/a17966

Patch Notes

Window Size: http://prntscr.com/a17a5x Full Screen: http://prntscr.com/a17ae3

General YGOPro Features

Replay: http://prntscr.com/a176x5 Deck Edit - Banlist begins from 2013-9-1; DevPro has their own "Custom Banlist" P1 - http://prntscr.com/a1777z P2 - http://prntscr.com/a177op

Game List

Empty - http://prntscr.com/a17amh Searching: http://prntscr.com/a17aue Hosting: http://prntscr.com/a17eot Hosted: http://prntscr.com/a17f7n

In-Game

After RPS - http://prntscr.com/a17fge Log - http://prntscr.com/a17gwf Settings - http://prntscr.com/

Chat Room

Users/Channel - http://prntscr.com/a17b49 Channel List - http://prntscr.com/a17ci3 User List / User Search, etc - http://prntscr.com/a17c5i Ignore Tab - http://prntscr.com/a17be0 Options Tab - http://prntscr.com/a17bnk , http://prntscr.com/a17bv0

Other DevPro Features

Access to Checkmate: http://prntscr.com/a178xb Customize - http://prntscr.com/a17du8 Customize Contents - http://prntscr.com/a17ecf File Manager - http://prntscr.com/a17dma Rankings - http://prntscr.com/a17ddk Support DevPro - http://prntscr.com/a17ek

Tragoedia commented 8 years ago

[Pics] YGOPRO Percy

Main Menu

Main Tab - http://prntscr.com/a18b5u Help Tab - http://prntscr.com/a18bni

Multiplayer

Online (General Interface) - http://prntscr.com/a18bsy Online (YGOPRO USA/EUROPE) - http://prntscr.com/a18cmr Online (Host Settings) - http://prntscr.com/a18cyo Online (Room Interface) - http://prntscr.com/a18d78 LAN Mode - http://prntscr.com/a18cgh

Checkmate

Menu - http://prntscr.com/a18lj2 Game Settings - http://prntscr.com/a18lp4

Dueling

Card Text - http://prntscr.com/a18mgx Card Log (Expanded) - http://prntscr.com/a18n3y Chat Log - http://prntscr.com/a18m51 Settings - http://prntscr.com/a18n98 Rematch Feature - http://prntscr.com/a18x2v

Ai Mode (Beta)

Host Settings - http://prntscr.com/a18iiv Deck Selection - http://prntscr.com/a18iys VS AI - http://prntscr.com/a18jgt

Puzzle Mode

List of Puzzles - http://prntscr.com/a18kj4 Demonstration (QB003.lua) - http://prntscr.com/a18ktq

Watch Replay

Menu - http://prntscr.com/a18l0j Demo - http://prntscr.com/a18laa

Deck Edit

YGOPRO Percy automatically searches for cards with the exact letters in the card text & name, unlike DevPro. General Interface - http://prntscr.com/a18dm

ghost commented 8 years ago

Is there an open source launcher i can look at?

Zayelion commented 8 years ago

DevPro and Salvation are opensource, but Salvations launcher was recently defuncted. There is also the ThaiPro one.

ghost commented 8 years ago

What is thaipro?

Zayelion commented 8 years ago

https://github.com/YGOProTH

ghost commented 8 years ago

1.Who decide? 2.Who fund? If we don't make it clear, we will progress very slowly.

Zayelion commented 8 years ago

1.Who decide? 2.Who fund? If we don't make it clear, we will progress very slowly.

Variant Owners, these people have servers and means of income to keep YGOPro servers on and avaliable : @zh99998 @SuperAndroid17 @Zayelion @Moonlightsorrow @mercury233 @Tic-Tac-Toc

They also usually do "most" of the programming and/or decision making on their variants, there are other people involved in the process. For myself at Salvation all the workers are volunteers, and directing volunteer works is very difficult. As part of our charter I make all executive decisions. I believe all the other variants are the same way but we are all at the mercy of any code changes that happen at this repository.

From a professional standpoint looking at YGOPro as a product with active comsumers the first step is basic business analysis for comsumer needs. I feel @Percival18 has done a wonderful job with that in his variant as pictured above and so has the DevPro team. Specifically for "who decides", what we build as a community, its our end users, the non-programmers. We ask them what they want, we prioritize it as variant owners, and divide the work while having strong communication.

There are different variants only because there are differences in listening to which user base, deciding on funding, and implementation details.

Is there any argument with that from anyone?

ghost commented 8 years ago

I feel that there is no need for multiple English based ygopros. If the staff from each sim comes together for one project and work on what they where doing before but for one sim. I think that would make things go faster/smoother and improve the sim.. For example Percy and Iceygo are good at working on the g-frame,since that is the case they should work on the g-frame for this one sim. Sid is good at working on launchers so he should work on the one launcher. Moonlight is good in the custom card department so they should work on that. Salv is good with the browser mode so they should work on that etc etc. The point i'm making is that if the ygopro community jumped on one sim which would mostly likely be salv and work on it we would eliminate the need for different sims. The simplest way to put this is if two game company's had basically the same idea for a game, so instead of competing they come to together and make the best game using their ideas. This basically covers the idea Zay posted at the top about dishing out work but it would be for one sim everyone agrees should be the main focus to improve.

Zayelion commented 8 years ago

I feel that there is no need for multiple English based ygopros.

Works in theory not in practice, communication between teams is strained at best and there have been attempted mergers and those did not work out hince this thread. We can all agree on that specific features need to be in the main line of the gframe because we all keep individually reimplementing them. How the sim is ran day to day, governed, and further feature implementation is extremely grey. All Im saying at this point is that we all identify ourselves as resources working on the project at for the time being and implement the features that we all agree on, nothing more.

Those features have already been outlined and once implemented will allow more innovation and fair competition between each of our sims.

ghost commented 8 years ago

When changing side, even other situasions in ygopro, there is a possibility of crash. Why and how to solve?

Zayelion commented 8 years ago

We've historically solved this by disabling DirectX

ghost commented 8 years ago

In that case, without D3D, do OPENGL become neccesary for ygopro?

Zayelion commented 8 years ago

Some computers still run slow without DirectX, just straight up fixing the bug is the better option.

StormWulf commented 8 years ago

It's a client-side issue for some older computers. You're better off giving an option to the user if they want DirectX enabled. What needs to happen is upgrading the DirectX in ygopro.

MistressMele commented 8 years ago

I do a bit everything I don't know what I am exactly

ghost commented 8 years ago

@Zayelion How far away are you guys from salv's auto scripter being fully functional. http://i.imgur.com/zLEIZYX.png

Zayelion commented 8 years ago

Salv doesnt have an autoscripter

Zayelion commented 8 years ago

Duel Stadium http://i.imgur.com/DmqqZ3E.jpg http://i.imgur.com/0ButVyH.jpg

Thats the KC logo. One of Seto's projects? Where did you get these pictures from? Out of context they look like one of Setos PR stunts. :-/

Zayelion commented 8 years ago

Lets try to keep the conversation on YGOPro and its variants.

ghost commented 8 years ago

https://github.com/thomasneff/YGOPRODraft What would be the case use for something like this?

ghost commented 8 years ago

@Zayelion @SuperAndroid17 @Moonlightsorrow @Tic-Tac-Toc What is the main purpose for each of your Ygopro simulators?

Zayelion commented 8 years ago

Salvation has a few purposes, they are mostly to address the failings of other simulators.

My personal modivations in addition to the above is my aversion and loathing hatred of stupidity. Users are very loud and clear in what they want and its the shear fact that I know no one here is gonna understand what I just said that keeps me going. As a programmer, Im tired of seeing hundreds if not thousands of children subjected to another laziness and hard headiness, and the egos of the people that those traits empower.

As for DevPro, my intention was to do all the above when I suggested to the other founders that we leave Dawn. The owner was abusive to the developers hence the name "dev" Pro, its focused on the devs not the moderators running the system. I got pushed out by the other devs and in an effort to protect my team split off yet again to Salvation.

ghost commented 8 years ago

@Zayelion @SuperAndroid17 What are your overhead costs ie server hosting,playing staff salary etc etc? I am trying to get a clear working of what it takes to be a variant owner.

Zayelion commented 8 years ago

That's confidential to each server owner for legal reasons.

zh99998 commented 8 years ago

my dueling server is about 1 cpu core, 6GB memory and 5M network, x2. and many others server like web, forum. no staff salary.

Zayelion commented 8 years ago

https://github.com/SalvationDevelopment/YGOPro-Salvation-Server/tree/master/documentation https://github.com/Fluorohydride/ygopro/blob/master/README.md https://github.com/Fluorohydride/ygopro-core/blob/master/README.md https://github.com/Fluorohydride/ygopro-pre-script/blob/master/README.md https://github.com/IceYGO/ygosharp/blob/master/README.md https://github.com/mycard/RecordAnalyzer/blob/master/readme.md https://github.com/mycard/ygopro-server/blob/master/README.md https://github.com/SalvationDevelopment/YGOPro-Salvation-Server/blob/master/readme.md https://github.com/Snarkie/YGOProAIScript/blob/master/AI%20Scripting%20Tutorial.md https://github.com/SalvationDevelopment/ygopro-tcg-scripts/blob/master/readme.md https://github.com/Buttys/DevProLauncher/blob/master/readme.md https://github.com/247321453/DataEditorX/blob/master/README.md https://github.com/SalvationDevelopment/YGOPro-Library-Builder/blob/master/README.md https://github.com/yjqww6/deckmanager/blob/master/README.md

Might be a few more... all I could find with a quick search.

Lee-ygopro commented 7 years ago

How far has work gotten on ygopro international? We also need to select leaders for each team and then divy out the work.

Zayelion commented 7 years ago

After speaking in private most of us have individual goals and views on how things should work and how they should be managed and implemented to the point that its devolved to "a friendly competition".

Lee-ygopro commented 7 years ago

That's not beneficial to the community or the end user and only serves to build up egos. The only important thing should be the end user.

Zayelion commented 7 years ago

Each leader feels they are doing the best for their community nor does everyone want to work with the existing code bases.

Lee-ygopro commented 7 years ago

Feels is the keyword here which doesn't translate to what the end user is feeling.. The current ygopro source is horribly mismanaged and is being left to rot. Which is why we should work on a rebase of the source which would help everyone out in the long run.

Zayelion commented 7 years ago

The code base is rotting because pull request are not being taken. There have been multiple attempts to improve the code base. FH knows this and even started rewriting the whole UI. Conversation around what should be done and how like this one end with no code getting commited to the base so we have each started working on different versions of ygopro.

Even after not being able to land code here each of us have our own personal issues that make it hard for us to work together.

The solution would be for pull request to start being taken, or everyone agree to commit to a new place.