Foddy / node-red-contrib-huemagic

Philips Hue node to control bridges, lights, groups, motion sensors, temperature sensors and Lux sensors using Node-RED.
https://flows.nodered.org/node/node-red-contrib-huemagic
Apache License 2.0
201 stars 67 forks source link

Active development #324

Open MBombeck opened 2 years ago

MBombeck commented 2 years ago

Hi @Foddy,

i don't want to stress. There are some open PR in this repo and some relatively annoying bugs. I fully understand that this is an open source project that you are putting your free time into.

I find the new v4 version great and use node-red-contrib-huemagic daily and am very happy with it. But the enthusiasm of all the other housemates is fading though.

Can you foresee if you can put some time into this project in the near future?

xoxoxo

Supergiovane commented 2 years ago

Following...

lougreenwood commented 2 years ago

@Foddy Thanks for all of your work on this project - and please don't see this as an attempt to pressure you.

Since the project seems to be slowing, have you considered giving a trusted contributor merge access so that some of these PRs can be merged?

Foddy commented 2 years ago

Sure! But there are unfortunately not that many people who are contributing that frequently :S

ptweety commented 2 years ago

@Foddy: I just recently stumbled into node development, even if I'm not a developer at all. One of my first issues was the setup of a dev environment. Maybe it could help others to contribute if the project provides some guides / references / how-to's?

I'm using vscode and helped myself with some changes in my local package.json:

  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1",
    "start": "node ./node_modules/node-red/red.js -s ./.node-red/settings.js -u ./.node-red",
    "inspect": "node --inspect ./node_modules/node-red/red.js -s ./.node-red/settings.js -u ./.node-red",
    "develop": "npm install && npm install --only=dev",
    "pretty": "./node_modules/.bin/prettier --check \"huemagic/**/*.js\"; exit 0",
    "lint": "./node_modules/.bin/eslint --fix-dry-run \"huemagic/**/*.js\"; exit 0"
  },
  "devDependencies": {
    "eslint": "^8.11.0",
    "eslint-config-prettier": "^8.5.0",
    "eslint-plugin-prettier": "^4.0.0",
    "node-red": ">=2.1.0",
    "prettier": "^2.6.0"
  }

A simple npm run develop pulls all the required modules and a rpm run start, starts Node-Red.

In addition I have a folder .node-red with a settings.js as follows:

module.exports = {
    flowFile: './.node-red/flows.json',
    userDir: './.node-red/',
    credentialSecret: 'dummy'
};

as well as a .eslint.yml and .prettierrc.

If this helps I could provide a pull request for the same.