ReferenceError: l is not defined - animation with group - Githubissues

Foddy / node-red-contrib-huemagic

Philips Hue node to control bridges, lights, groups, motion sensors, temperature sensors and Lux sensors using Node-RED.

https://flows.nodered.org/node/node-red-contrib-huemagic

Apache License 2.0

200 stars 67 forks source link

ReferenceError: l is not defined - animation with group #355

Open ptweety opened 2 years ago

ptweety commented 2 years ago

Hi @Foddy,

I wonder if in the following code block this little l in currentState.info.lightIds[l] is defined anywhere.

https://github.com/Foddy/node-red-contrib-huemagic/blob/1af6c29676c0cabd02f2cd1b105b95acff24d77f/huemagic/hue-group.js#L360-L376

Well, in fact it's a bug:

How to reproduce

import the HueMagic example
select any animation in the node
replace the light node with a group node
start the animation

In the log you will find:

25 Mar 22:09:28 - [error] ReferenceError: l is not defined
    at patchObject.on ([.../node-red-contrib-huemagic/huemagic/hue-group.js:360:55]())