Commands dropped / bridge overloaded (Err=429) / Connexion issues

[FredBlo]

Context : HUEMagic becomes more often unusable

Based on what I read, it seems HUE has became more and more strict in what it accepts in terms of external API call rates. Where the bridge easily accepted many calls per second before, it now rejects them more frequently. Official HUE dev documentation now mentions a maximum of 4 calls per second (but even more strict for calls to groups which are limited to 1 call / second...) HUEMagic already handled a retry but :

• it only managed it for error code '503'... but now the bridge responds -most of the time- with '429' in case of overload
• retry was performed 3 times (after 2s, then 4s, then 8s) These caused many issues with commands being delayed to completely lost (not executed).
• The bridge connection was also often 'reset', with an error on console Error requesting info from the bridge. Reconnect in some secs. undefined. This was caused when HUEMagic polled the bridge to ensure connection was still OK at a moment when the bridge was overloaded (err=429)

Because of this, most of us were not able to enjoy HUEMagic nodes :-(

What did I change ?

• Error '429' is now correctly taken into account (as was 503 before)
• All calls will be retried up to 5 times
• Retry delay will extended by 750ms each time (i.e. 0,75s, 1,5s, ... 3,75)
• HUEMagic will no longer reset connection when it responds as being overloaded
• (In case of connection error, the full returned content (page) is send to console for easier debug) I have now been running this config for a few weeks and I do not have any connection / drops anymore.

Additional info : merge of other

This pull request also merged #390 from @traverseda and #381 from @Travelbacon, which corrected -very successfully- bugs #375, #374, #377 and #378. Since then other group issues were reported which should also be solved since I think these are actually the same... (such as #400)

What you need to do / change ?

I strongly recommend to configure your HUEMagic bridge node using a single 'worker'. Setting more than 1 will always -logically- worsen the overload effect on the bridge. If you want to use it from now (not waiting for Foddy to merge & publish it), this is possible by installing it manually using command npm install git+https://github.com/fredblo/node-red-contrib-huemagic.git

[Travelbacon]

Thank you so much for doing this!

[arw-thomasm]

Thank you for your work! I tested it and it works like charme! @Foddy can you please merge this PR soon?

[dongennl]

@Foddy this is really necessary ,please can you consider giving @FredBlo merging rights since he contributes a lot lately. It would help everybody