search

ForgeRock / exampleOAuth2Clients

Example OAuth2 clients for standards-based profile management
ISC License
36 stars 18 forks source link

Update README.md #56

Closed lorig135 closed 5 years ago

lorig135 commented 5 years ago

Creating a PR for your review.

lorig135 commented 5 years ago

Thank you.

On Wed, Sep 4, 2019 at 3:15 PM Konstantin Lapine notifications@github.com wrote:

@lapinek commented on this pull request.

In iOS-AppAuth/SSO/README.md https://github.com/ForgeRock/exampleOAuth2Clients/pull/56#discussion_r320978906 :

@@ -39,19 +39,19 @@ Here, we will discuss three options for enabling SSO with session cookies when i

  • Authentication in Safari forces the user to leave the app
  • Safari tabs cannot be controlled from the app

- If calling the default browser for front-channel communications is not acceptable, enabling persistent cookies for session management could be an option in the authorization server configuration. This will allow for sharing authentication state in the iOS in-app browser tabs. An example of this approach is described in the Enabling Persistent Cookies in ForgeRock Access Management section. + If calling the default browser for front-channel communications is not acceptable, enabling persistent cookies for session management could be an option in the authorization server configuration. This will allow sharing the authentication state in the iOS in-app browser tabs. An example of this approach is described in the Enabling Persistent Cookies in ForgeRock Access Management section:

I think you need to make the changes, because it is a branch in your repo. Then squash the commits and push the resulting one to your origin lorig135-patch-2. Then rebase and merge and, optionally, delete your branch.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ForgeRock/exampleOAuth2Clients/pull/56?email_source=notifications&email_token=AISPLHKYHOFS56KBUOFQHELQIAQPNA5CNFSM4ITLWD62YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDV7VNQ#discussion_r320978906, or mute the thread https://github.com/notifications/unsubscribe-auth/AISPLHMGIBKS7SQS4YODZ4DQIAQPNANCNFSM4ITLWD6Q .

-- [image: ForgeRock] http://www.forgerock.com Lori Goldman Documentation Editor | ForgeRock t (303)717-2012 | e lori.goldman@forgerock.com firstname.lastname@forgerock.com skype lorig3833| web www.forgerock.com