search

FormidableLabs / builder-init

A project generator for builder archetypes.
MIT License
12 stars 2 forks source link

Ingest prompted, derived data from archetype/init.js #10

Closed ryan-roemer closed 8 years ago

ryan-roemer commented 8 years ago

Fixes #3

Parallel 'builder-react-component' branch: https://github.com/FormidableLabs/builder-react-component/compare/chore-init-prompts

Parallel 'builder-react-component' PR: https://github.com/FormidableLabs/builder-react-component/pull/30

/cc @coopy @benbayard @chaseadamsio @exogen @boygirl @zachhale

ryan-roemer commented 8 years ago

@baer @zachhale -- OK, I think I've got all comments covered / refactored. Appreciate another review pass!

zachhale commented 8 years ago

LGTM other than updating the README

ryan-roemer commented 8 years ago

@zachhale -- What does:

There are other places in this file where this change also needs to be made.

apply to?

zachhale commented 8 years ago

@ryan-roemer README has module.exports: in more cases where it should be module.exports =. One was updated but there are more that need updating.

ryan-roemer commented 8 years ago

@zachhale -- Gotcha! I think i've got them all now. Thanks for the attention to detail!

zachhale commented 8 years ago

LGTM

baer commented 8 years ago

You and that async lib - Promises be damned :)

LGTM :ship: