search

FormidableLabs / builder-init

A project generator for builder archetypes.
MIT License
12 stars 2 forks source link

Adjust npm pack spawn for windows. #30

Closed ryan-roemer closed 8 years ago

ryan-roemer commented 8 years ago

Ok, this actually seems to be a pretty simple fix. I've manually vetted this against mac and windows. Fixes #27

@LittleBrainz -- Can you install this branch and confirm it works for you on your Windows machine?

/cc @coopy

P.S. I've also added #29 to keep Windows CI on our radar.

LittleBrainz commented 8 years ago

@ryan-roemer -- I'm afraid I don't know how to "install this branch".

I originally ran npm install --save-dev builder builder-react-component builder-react-component-dev.

Should I manually replace node_modules/builder/lib/task.js?

ryan-roemer commented 8 years ago

@LittleBrainz -- Sure! Follow these steps:

$ npm rm -g builder-init
$ npm install -g FormidableLabs/builder-init#bug-windows-spawn

After that the original command that you tried:

$ builder-init builder-react-component

Should work with you get prompts to initialize a new project from scratch.

LittleBrainz commented 8 years ago

@ryan-roemer -- Yes, everything seems to be working. A big thank you!

Apologies for the strangeness of my last message. I hadn't yet had my morning cup of coffee, so everything I did and said was complete nonsence and gibberish.

Another result! Today I learned that I can NPM install from a GitHub branch. Cool!

ryan-roemer commented 8 years ago

Released in builder-init@0.2.2