FosterFramework / Foster

A small C# game framework
MIT License
450 stars 37 forks source link

Mesh changes #4

Closed MrBrixican closed 1 year ago

MrBrixican commented 1 year ago

Hey, awesome work on this library! When I saw that you recreated it, it was a very nice surprise to start the weekend.

However, I noticed some differences from the original implementation:

If these omissions were to make the initial c implementation easier and is something that you already intended to refactor at some point, please disregard this issue.

Thanks once again for working on this great library!

NoelFB commented 1 year ago

Hey! I think all of these are good ideas. The Instance data was something I planned to add back but I just have not actually used it yet, so it wasn't a priority. The first two issues I'd like to fix more immediately though, I didn't realize the performance issue there.

NoelFB commented 1 year ago

OK I've updated the Mesh API to both use glBufferSubData and allow an offset to upload into. I'm going to close this for now and create a new issue for eventually adding Mesh Instancing back. Thanks for the input! :)