Fragjacker / DoW-Mod-Manager

The original repository for the DoW Mod Manager application, which was made for the Dawn of War:tm: series.
MIT License
33 stars 7 forks source link

1.8.1 is here! Smaller EXE and a few optimizations! #11

Closed IgorTheLight closed 4 years ago

IgorTheLight commented 4 years ago

I think it's still worth the update! Also added disclaimer in README.MD that this application could be dangerous and we have zero responsibilities fort that! ;-)

IgorTheLight commented 4 years ago

You didn't merged the 1.8.0? This is heresy! ;-)

Fragjacker commented 4 years ago

Well I just skipped 1.8.0 and merged 1.8.1 right away 😀 . Also one thing I noticed is that this may collide with the -nomovies option:

image

-nomovies disables the intro movies, that are played when starting the game. So there may be a clash, unless that option refers to the stronghold movies, played in the campaign 🤔 . Other then that this is a very cool feature!

Also when selecting the player profile it would be cool if the user could create a new profile right from that window. image Since some people reported in the past that the game won't allow them to create a new profile if they start the game with a mod. So this could fix this!

Another suggestion would be to add tooltips/descriptions since some options may sound enigmatic like this one image So the folks know what effect changing that and similar options has on the game.

Fragjacker commented 4 years ago

Also updated the README.md file with a new picture that shows the full glory of the DoW Mod Manager v1.8.1 😀 make sure you pull them latest changes!

IgorTheLight commented 4 years ago

Nice work! Sorry for a small mess - I thought that you merged 1.8.0 before (you even hinted at that). But that problem is over now so it's fine :-) What exactly disables NoMovies? I have to test that actually. But it's NOT changing the "-nomovies" command - that I could assure you! Ok, I will add the ability to create new Profiles from Settings Manager. Probably in 1.9.0 What "rl_sso_num_times_shown" does - I'm not sure. There is only that information and it's about DoW2: https://community.dawnofwar.com/discussion/8413/connecting-relic-account-to-steam So it's related to the network and it shows a prompt? Something like that :-) Maybe I should rename it to "Show login prompt" or something... Did you saw how small DoW Mod Manager v1.8.1.exe is now ;-) I updated the screenshots - they are glorious! :-) I see that you have some Python + ML projects? Could I mess with them too? :-) I'm not sure that I want to, but who knows! Did you tried to compile Python code using Nuitka (for native performance)? python -m pip install nuitka And then create an EXE with: python -m nuitka --standalone your_main.py If you don't want to include dependencies: python -m nuitka your_main.py You probably know all of that already :-)

On Tue, Jun 16, 2020 at 2:34 PM Dennis S. notifications@github.com wrote:

Well I just skipped 1.8.0 and merged 1.8.1 right away 😀 . Also one thing I noticed is that this may collide with the -nomovies option:

[image: image] https://user-images.githubusercontent.com/19975052/84768957-64aa5200-afd5-11ea-971d-ab40ab49c221.png

-nomovies disables the intro movies, that are played when starting the game. So there may be a clash, unless that option refers to the stronghold movies, played in the campaign 🤔 . Other then that this is a very cool feature!

Also when selecting the player profile it would be cool if the user could create a new profile right from that window. [image: image] https://user-images.githubusercontent.com/19975052/84769199-be128100-afd5-11ea-9656-fb7973ae38f3.png Since some people reported in the past that the game won't allow them to create a new profile if they start the game with a mod. So this could fix this!

Another suggestion would be to add tooltips/descriptions since some options may sound enigmatic like this one [image: image] https://user-images.githubusercontent.com/19975052/84769323-eef2b600-afd5-11ea-9fc1-52c1076e4780.png So the folks know what effect changing that and similar options has on the game.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/11#issuecomment-644707256, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F37Q5MTTGVYILQUQNZDRW5KC5ANCNFSM4N7ONIOA .

Fragjacker commented 4 years ago

What exactly disables NoMovies?

It disables the intro movies when starting up the game.

Did you saw how small DoW Mod Manager v1.8.1.exe is now ;-)

That is indeed very cool. What was the culprit of it being so big? To many imports?

I see that you have some Python + ML projects?

Yeah you probably refer to that p-grad-CAM repo which is basically my Master Thesis project. Feel free to fork it. Though I have ran a profiler on the code and the majority of time is wasted on Tensorflow library functions.

However I have also have other Python projects too, which are yet private and unreleased, which could indeed benefit from nuitka, since I am using pyinstaller for them as of now. Will take a look at nuitka! Native performance is always appreciated 😁 .

IgorTheLight commented 4 years ago

"What exactly disables NoMovies?" - my bad - I mean "Watch Movies". I tested it and it does nothing (again - I mean "Watch Movies" option). If you turn it off - game will start and turn it on. So I think that's some kind of left-over. If you are curious - it's "force_watch_movies=1" in Local.ini Why DoW is much smaller now? That's because every Form created it's own copy of Icon resource. Let's count how many copies were there:

On Tue, Jun 16, 2020 at 4:09 PM Dennis S. notifications@github.com wrote:

What exactly disables NoMovies?

It disables the intro movies when starting up the game.

Did you saw how small DoW Mod Manager v1.8.1.exe is now ;-)

That is indeed very cool. What was the culprit of it being so big? To many imports?

I see that you have some Python + ML projects?

Yeah you probably refer to that p-grad-CAM repo which is basically my Master Thesis project. Feel free to fork it. Though I have ran a profiler on the code and the majority of time is wasted on Tensorflow library functions.

However I have also have other Python projects too, which are yet private and unreleased, which could indeed benefit from nuitka, since I am using pyinstaller for them as of now. Will take a look at nuitka! Native performance is always appreciated 😁 .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/11#issuecomment-644753079, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F35WXQYFX3LLQYRW273RW5VKJANCNFSM4N7ONIOA .

Fragjacker commented 4 years ago

Finally got Nuitka to work on my device 😀 . So far it produces a bigger executable then pyinstaller but also shows slightly better performance right off the bat. Guess it grabs more libraries and packs them into the standalone 🤔 .

IgorTheLight commented 4 years ago

You could try this experimental feature - it will grab less modules: python -m nuitka --standalone --experimental=use_pefile your_main.py

On Thu, Jun 18, 2020 at 8:06 PM Dennis S. notifications@github.com wrote:

Finally got Nuitka to work on my device 😀 . So far it produces a bigger executable then pyinstaller but also shows slightly better performance right off the bat. Guess it grabs more libraries and packs them into the standalone 🤔 .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/11#issuecomment-646179984, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F3Z5RDPUIL5WGFNPCCLRXJCRHANCNFSM4N7ONIOA .