search

Fragjacker / DoW-Mod-Manager

The original repository for the DoW Mod Manager application, which was made for the Dawn of War:tm: series.
MIT License
33 stars 7 forks source link

2.0.4 is here! "You requested a psyker, My Lord?" #17

Closed IgorTheLight closed 4 years ago

IgorTheLight commented 4 years ago

Version 2.0.4:

Fragjacker commented 4 years ago

@IgorTheLight I have done a little bit of research and found .NET Native which uses AOT compiler to translate .NET into antive machine code instead of Intermediate Language (IL). Maybe it's worth some further investigation if even more performance improvements can be gained using .Net Native unless you have done that already 😁 . Check this article out https://docs.microsoft.com/en-us/dotnet/framework/net-native/

Besides of that I will check out and review this pull ASAP.

Fragjacker commented 4 years ago

Also the merge conflicts are getting out of hand. Make sure you merged my master branch into yours and resolve the merge conflicts proper. I suggest using in situ apps like Meld or KDiff via command lines or similar.

Fragjacker commented 4 years ago

Other then that I recently wanted to give 4K resolution a try but it doesn't work for me. It just resets the resolution back to 800x600 each time I start the game and try to go beyond 1920x1080. The resolutions below that work but not 2K and 4K 😭 .

IgorTheLight commented 4 years ago

Oh thanks! But sadly it's only for UWP (Universal Windows Platform - Windows Store) programs :-( https://stackoverflow.com/questions/32607689/how-to-use-net-native-in-winform-and-c-sharp-visual-studio-2015 Maybe we could use it when .NET 5 comes out.

On Sat, Jul 25, 2020 at 1:45 PM Dennis S. notifications@github.com wrote:

@IgorTheLight https://github.com/IgorTheLight I have done a little bit of research and found .NET Native which uses AOT compiler to translate .NET into antive machine code instead of Intermediate Language (IL). Maybe it's worth some further investigation if even more performance improvements can be gained using .Net Native unless you have done that already 😁 . Check this article out https://docs.microsoft.com/en-us/dotnet/framework/net-native/

Besides of that I will check out and review this pull ASAP.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/17#issuecomment-663840649, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F36VEVMJMGCNGVHPZNTR5KZTDANCNFSM4PG365VA .

IgorTheLight commented 4 years ago

Maybe that's an engine limitation? I just assumed that DoW may run in any resolution but maybe that's not true. I'm not sure that I have to delete 2K and 4K options but if that will not for a few more people - I would! About merge conflicts. You will not like that idea but... may you just download my master as *.ZIP and unzip it in your folder? It's like 30 seconds. I didn't add any malicious code in DoW Mod Manager ;-) Resolving it in a "proper way" may take 20-30 minutes. Do we really have to check every line of code? Let's say I changed something that you didn't like - you may "checkout" a previous commit and your code will be fine :-) There are only two contributors - it's not like we will brake anyone else's code (kids, please don't do that at home!)

On Sat, Jul 25, 2020 at 3:42 PM Dennis S. notifications@github.com wrote:

Other then that I recently wanted to give 4K resolution a try but it doesn't work for me. It just resets the resolution back to 800x600 each time I try to go beyond 1920x1080. The resolutions below that work but not 2K and 4K 😭 .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/17#issuecomment-663851335, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F3YTASODLBNMYK67RODR5LHK7ANCNFSM4PG365VA .

Fragjacker commented 4 years ago

Well the issues have to be addressed at some point. Just copypasting your files over mine without further inspection could nuke potential changes and just going one commit back would nuke your changes in return 😀 . I gotta maybe do the merge tomorrow or so for you but then make sure to apply the latest master branch from my repo onto yours.

Reason being that if you don't update it I'll keep getting the same issues over and over for each new pull request you do piling up higher and higher. Once you applied the my laters master onto yours I'll only have to fix merge conflicts from that commit in time, instead of the X commits behind the last time you updated your master branch from my repo 😁 .

IgorTheLight commented 4 years ago

Ok. I will check your changes. I hope there are not many of them... That's really tedious even if I can see the diffs. Or maybe I'm just lazy :-)

On Sun, Jul 26, 2020 at 8:55 PM Dennis S. notifications@github.com wrote:

Well the issues have to be addressed at some point. Just copypasting your files over mine without further inspection could nuke potential changes and just going one commit back would nuke your changes in return 😀 . I gotta maybe do the merge tomorrow or so for you but then make sure to apply the latest master branch from my repo onto yours.

Reason being that if you don't update it I'll keep getting the same issues over and over for each new pull request you do piling up higher and higher. Once you applied the my laters master onto yours I'll only have to fix merge conflicts from that commit in time, instead of the X commits behind the last time you updated your master branch from my repo 😁 .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/17#issuecomment-664020286, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F32JNKJZZIQE4CWM273R5RUXVANCNFSM4PG365VA .

IgorTheLight commented 4 years ago

I checked the difference between my master and your master - yep! I want those changes in 2.0.4 Nothing suspicious! It's just too many changes for poor GitHub to handle :-) You could ask about any change if you want to (just copy the code or say where it's situated)

On Sun, Jul 26, 2020 at 10:23 PM Igor Sandu igorthelight@gmail.com wrote:

Ok. I will check your changes. I hope there are not many of them... That's really tedious even if I can see the diffs. Or maybe I'm just lazy :-)

On Sun, Jul 26, 2020 at 8:55 PM Dennis S. notifications@github.com wrote:

Well the issues have to be addressed at some point. Just copypasting your files over mine without further inspection could nuke potential changes and just going one commit back would nuke your changes in return 😀 . I gotta maybe do the merge tomorrow or so for you but then make sure to apply the latest master branch from my repo onto yours.

Reason being that if you don't update it I'll keep getting the same issues over and over for each new pull request you do piling up higher and higher. Once you applied the my laters master onto yours I'll only have to fix merge conflicts from that commit in time, instead of the X commits behind the last time you updated your master branch from my repo 😁 .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/17#issuecomment-664020286, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F32JNKJZZIQE4CWM273R5RUXVANCNFSM4PG365VA .

Fragjacker commented 4 years ago

Alright today I won't have time to merge this but hopefully tomorrow 😬 .

IgorTheLight commented 4 years ago

It's fine :-)

On Tue, Jul 28, 2020 at 5:32 PM Dennis S. notifications@github.com wrote:

Alright today I won't have time to merge this but hopefully tomorrow 😬 .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/17#issuecomment-665076263, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F36CXNENX2F47SZDUOTR53OQTANCNFSM4PG365VA .

Fragjacker commented 4 years ago

Alright I merged plus did some small changes to the checkboxes changing them to radio buttons as this simplifies the activation/deactivation code as radio buttons only allow one selection at a time anyways.

Make sure you update your master branch with the latest goodies 😀 .

IgorTheLight commented 4 years ago

Thanks! That was a leftover, because you TECHNICALLY could use both optimizations at the same time. But if you do so - application will run slow ("cold start" but after that it will just use AOT and be fast). So:

On Wed, Jul 29, 2020 at 4:04 PM Dennis S. notifications@github.com wrote:

Alright I merged plus did some small changes to the checkboxes changing them to radio buttons as this simplifies the activation/deactivation code as radio buttons only allow one selection at a time anyways.

Make sure you update your master branch with the latest goodies 😀 .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/17#issuecomment-665650745, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F33YKJMYMOONLDNLQJLR6AM4LANCNFSM4PG365VA .

IgorTheLight commented 4 years ago

I added 2.0.5 to my Releases. Please sync it with your master because I added changelog (in *.txt and in AboutForm). Also I fixed a few comment typos. My plans for 2.1.0:

On Wed, Jul 29, 2020 at 6:37 PM Igor Sandu igorthelight@gmail.com wrote:

Thanks! That was a leftover, because you TECHNICALLY could use both optimizations at the same time. But if you do so - application will run slow ("cold start" but after that it will just use AOT and be fast). So:

  • Multoothreaded JIT - first start is slow (but still a little bit faster than Singlethreaded), all starts after first are faster.
  • AOT - first and all other starts are fast and application is faster than before.
  • MultiJIT + AOT - first start is slow (because of a JIT Compilation) but others are fast (because it will use AOT). So you just make your first start slow and gain nothing. That's why I disabled the feature to use both of them at the same time. Thanks for making it more convenient :-) I will sync my master with yours.

On Wed, Jul 29, 2020 at 4:04 PM Dennis S. notifications@github.com wrote:

Alright I merged plus did some small changes to the checkboxes changing them to radio buttons as this simplifies the activation/deactivation code as radio buttons only allow one selection at a time anyways.

Make sure you update your master branch with the latest goodies 😀 .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/17#issuecomment-665650745, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F33YKJMYMOONLDNLQJLR6AM4LANCNFSM4PG365VA .

Fragjacker commented 4 years ago

I added 2.0.5 to my Releases. Please sync it with your master because I added changelog (in *.txt and in AboutForm). Also I fixed a few comment typos.

I pulled your latest changes into my branch.

  • Add Large Font support

I think different resolutions require some hex editing of core game files. Take a look at this repo here: https://github.com/zero334/Dawn-of-War-Widescreen-Fix

  • Delete changelog for 2.0.0 - 2.0.5 and replace it with a GitHub link to a changelog.txt
  • Delete version number and "Written by FragJacker" in ModMergerForm. The reason for that is that we have a proper AboutForm with all information about authors and our application is monolithic and we can't update one Form but not others.

I agree since this has became a multicollabarion project now and credits are sorter differently now. Especially like the changelog.txt on github. I think we should go the same route with the file that contains the download links when attempting to download mods. That would make updating them much easier. Currently we have to do a minor release so that the app autoupdates with the inbuilt text definitions, which is problematic.

  • Add emails for authors. I would give this email - igorthelight@gmail.com What would be yours (if you want to give one)?

My Email is littered enough with Emails already 😛 . I think just linking this repository should be enough.

IgorTheLight commented 4 years ago

About fonts - I remember there were the config-like files with font sizes - no Hex editing needed! I will check that tomorrow! About mod download information in a separate file - yes I will add that too in 2.1.0 May you ask the creators of those active mods to add a link to a DoW Mod Manager?

On Thu, Jul 30, 2020 at 4:46 PM Dennis S. notifications@github.com wrote:

I added 2.0.5 to my Releases. Please sync it with your master because I added changelog (in *.txt and in AboutForm). Also I fixed a few comment typos.

I pulled your latest changes into my branch.

  • Add Large Font support

I think different resolutions require some hex editing of core game files. Take a look at this repo here: https://github.com/zero334/Dawn-of-War-Widescreen-Fix

  • Delete changelog for 2.0.0 - 2.0.5 and replace it with a GitHub link to a changelog.txt

  • Delete version number and "Written by FragJacker" in ModMergerForm. The reason for that is that we have a proper AboutForm with all information about authors and our application is monolithic and we can't update one Form but not others.

I agree since this has became a multicollabarion project now and credits are sorter differently now. Especially like the changelog.txt on github. I think we should go the same route with the file that contains the download links when attempting to download mods. That would make updating them much easier. Currently we have to do a minor release so that the app autoupdates with the inbuilt text definitions, which is problematic.

  • Add emails for authors. I would give this email - igorthelight@gmail.com What would be yours (if you want to give one)?

My Email is littered enough with Emails already 😛 . I think just linking this repository should be enough.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/17#issuecomment-666374509, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F34UWHOQS3RBGCIHKF3R6F2THANCNFSM4PG365VA .

Fragjacker commented 4 years ago

About fonts - I remember there were the config-like files with font sizes - no Hex editing needed! I will check that tomorrow!

The hex editing was done for unlocking additional resolutions. The font size fix was I guess needed if someone set their system resolution to 4K. As setting the game via the local.ini to 4K doesn't work, the game just resets to 800x600 default resolution. My theory was that it may be possible to adapt the resolution hack to unlock true 4K resolution from the game itself.

Any chance you can add support for 16:10 resolutions?

One guy requested the addition of 16:10 resolutions such as 1900x1200 and similar I think this would make a fine addition to our feature collection.

May you ask the creators of those active mods to add a link to a DoW Mod Manager?

I know the unification team very well. In fact there may be a new release soon which will include the latest Mod Manager inside the installer (that I will create as I have the technology) plus hosting it on their page. The imperial fists mod is also no news for me as I pretty much am in touch with all the big boys of the modding community. There's a lot more new mods in the pipe too so we may need to add more in the future.

Hence having a separate file for mod links would be indeed of virtue.

IgorTheLight commented 4 years ago

I will investigate unlocking additional resolutions. Adding 16:10 would be not hard (theoretically). Nice news about new mods! I will add a separate file for easier handling of mods. Also - you could play around with my last version: https://github.com/IgorTheLight/DoW-Mod-Manager/raw/master/DoW%20Mod%20Manager/LatestStable/DoW%20Mod%20Manager.exe

On Fri, Jul 31, 2020 at 1:59 PM Dennis S. notifications@github.com wrote:

About fonts - I remember there were the config-like files with font sizes - no Hex editing needed! I will check that tomorrow!

The hex editing was done for unlocking additional resolutions. The font size fix was I guess needed if someone set their system resolution to 4K. As setting the game via the local.ini to 4K doesn't work, the game just resets to 800x600 default resolution. My theory was that it may be possible to adapt the resolution hack to unlock true 4K resolution from the game itself.

Any chance you can add support for 16:10 resolutions?

One guy requested the addition of 16:10 resolutions such as 1900x1200 and similar I think this would make a fine addition to our feature collection.

May you ask the creators of those active mods to add a link to a DoW Mod Manager?

I know the unification team very well. In fact there may be a new release soon which will include the latest Mod Manager inside the installer (that I will create as I have the technology) plus hosting it on their page. The imperial fists mod is also no news for me as I pretty much am in touch with all the big boys of the modding community. There's a lot more new mods in the pipe too so we may need to add more in the future.

Hence having a separate file for mod links would be indeed of virtue.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/17#issuecomment-667063808, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F37SVJINBTE7X6ADJBLR6KPZZANCNFSM4PG365VA .

IgorTheLight commented 4 years ago

Hi! I've added a few most common 16:10 resolutions, made most Forms resizable, added the ability to read external modlist file (and ability to update it automatically). Never got the time to add large fonts. There are no problems - just didn't have time for that. Changes so far:

Version 2.1.0 (Work in progress):

I think we have to release this version soon so we don't get "feature creep". Too many changes is also much harder to test!

On Fri, Jul 31, 2020 at 2:58 PM Igor Sandu igorthelight@gmail.com wrote:

I will investigate unlocking additional resolutions. Adding 16:10 would be not hard (theoretically). Nice news about new mods! I will add a separate file for easier handling of mods. Also - you could play around with my last version: https://github.com/IgorTheLight/DoW-Mod-Manager/raw/master/DoW%20Mod%20Manager/LatestStable/DoW%20Mod%20Manager.exe

On Fri, Jul 31, 2020 at 1:59 PM Dennis S. notifications@github.com wrote:

About fonts - I remember there were the config-like files with font sizes

no Hex editing needed! I will check that tomorrow!

The hex editing was done for unlocking additional resolutions. The font size fix was I guess needed if someone set their system resolution to 4K. As setting the game via the local.ini to 4K doesn't work, the game just resets to 800x600 default resolution. My theory was that it may be possible to adapt the resolution hack to unlock true 4K resolution from the game itself.

Any chance you can add support for 16:10 resolutions?

One guy requested the addition of 16:10 resolutions such as 1900x1200 and similar I think this would make a fine addition to our feature collection.

May you ask the creators of those active mods to add a link to a DoW Mod Manager?

I know the unification team very well. In fact there may be a new release soon which will include the latest Mod Manager inside the installer (that I will create as I have the technology) plus hosting it on their page. The imperial fists mod is also no news for me as I pretty much am in touch with all the big boys of the modding community. There's a lot more new mods in the pipe too so we may need to add more in the future.

Hence having a separate file for mod links would be indeed of virtue.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/17#issuecomment-667063808, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F37SVJINBTE7X6ADJBLR6KPZZANCNFSM4PG365VA .