search

Fragjacker / DoW-Mod-Manager

The original repository for the DoW Mod Manager application, which was made for the Dawn of War:tm: series.
MIT License
32 stars 7 forks source link

Small changes (mostly mods updates) #23

Closed IgorTheLight closed 3 years ago

Fragjacker commented 3 years ago

It's been a while since I've seen you, good you're still around 😀.

IgorTheLight commented 3 years ago

I'm still alive :-) Glad to hear from you too!

On Sat, Dec 19, 2020 at 5:40 PM Dennis S. notifications@github.com wrote:

It's been a while since I've seen you, good you're still around 😀.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/23#issuecomment-748489793, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F3YWGFNAD3OYG7YD3ADSVTCPNANCNFSM4VCKRYVA .

IgorTheLight commented 3 years ago

But... I did that! Didn't I?

On Sun, Dec 20, 2020 at 3:38 PM Dennis S. notifications@github.com wrote:

@Fragjacker requested changes on this pull request.

I see the the mod version is 2.1.2 though I have pushed a small update in the past to put the mod to 2.1.3 so make sure you merge the latest changes proper so we don't go back in the version number.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/23#pullrequestreview-556018584, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F35IU5DD4A7BHTVZJQLSVX437ANCNFSM4VCKRYVA .

IgorTheLight commented 3 years ago

My "master" branch is synced with 2.1.3 - https://github.com/IgorTheLight/DoW-Mod-Manager You may check it. Very strange...

IgorTheLight commented 3 years ago

Looks like a bug. Could you just take my "DoW Mod Manager Download Mods.list" and "version" files - that's all that I modified since your 2.1.3 Sorry for adding some problems :-)

On Mon, Dec 21, 2020 at 5:30 PM Dennis S. notifications@github.com wrote:

@Fragjacker commented on this pull request.

Have a look at commit ef05b4f https://github.com/Fragjacker/DoW-Mod-Manager/commit/ef05b4f873e8e307d24780b635eda070b1ffe7bd. The files in this pull request are all faulty since it shows version 2.1.2 which is outdated. So I don't know what happened here but those are definitely bad changes. Maybe something went wrong with the pull request creation.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/23#pullrequestreview-556463349, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F35PCA4LMHDMBFHY4B3SV5SY3ANCNFSM4VCKRYVA .

IgorTheLight commented 3 years ago

Thanks! Now you have the latest mods :-)

On Thu, Dec 24, 2020 at 3:41 PM Dennis S. notifications@github.com wrote:

Merged #23 https://github.com/Fragjacker/DoW-Mod-Manager/pull/23 into master.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/23#event-4147476846, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F3633765SKKUFVG7RRTSWNAHZANCNFSM4VCKRYVA .