Fragjacker / DoW-Mod-Manager

The original repository for the DoW Mod Manager application, which was made for the Dawn of War:tm: series.
MIT License
32 stars 7 forks source link

Audio Slider settings not being saved. #27

Closed Neon-Oyun closed 3 years ago

Neon-Oyun commented 3 years ago

Hi!

Neon from Unification Discord here.

The mod manager (2.16) does not save audio volume settings, nor the “random sound” setting either.

The audio volumes can be set ingame using the game's own sliders and the game will remember it. But it will not be reflected when looking in the mod manager. And on seemingly random occasions the mod manager’s (default) volume settings will override the game’s settings.

Launching as admin does nothing. There are no lines for audio settings in the modmanager.ini or the local.ini, but that could be by design.

EDIT: 3 confirmed cases (including me), I think there has been one or two further back reported in Unification tech-support.

Fragjacker commented 3 years ago

I may tag @IgorTheLight for this is well, since the settings window is his baby. We'll look into fixing this.

Fragjacker commented 3 years ago

Alright @Neon-Oyun this issue should be fixed as of commit b6fcfd27bcca8dbef83acb7088958906e43d00d2 published just now.

Neon-Oyun commented 3 years ago

Wow that was fast! Tested it and it seems to be working as intended now :)

IgorTheLight commented 3 years ago

I didn't even had time to react :-) I will test those changes too! Disclaimer: I didn't even touched the new code at all - all credit goes to Fragjacker :-)