search

Fragjacker / DoW-Mod-Manager

The original repository for the DoW Mod Manager application, which was made for the Dawn of War:tm: series.
MIT License
32 stars 7 forks source link

Updated .NET FRamework to 4.8 and enabled HDPI support #3

Closed IgorTheLight closed 4 years ago

IgorTheLight commented 4 years ago
IgorTheLight commented 4 years ago

Thanks for reply. HDPI is hard to tweak: when it looks good with 100% - it looks weird on 100%+. And vise versa. I thing it will be a smarter idea to do this step by step (instead what I did). So I will do that is a few steps:

On Fri, May 1, 2020 at 3:47 PM Dennis S. notifications@github.com wrote:

@Fragjacker requested changes on this pull request.

The normal Mod window has some issues with the labels for the windows as they appear in the wrong place when the window is maximized.

[image: image] https://user-images.githubusercontent.com/19975052/80806200-4c63ac80-8bba-11ea-8353-1bd543496637.png

The Mod Merger UI is busted as well as important UI elements are suddenly gone. Below image shows the Mod Merger from your pull and the right is the one from my old v1.52 as how it should look like.

[image: image] https://user-images.githubusercontent.com/19975052/80806008-c8a9c000-8bb9-11ea-9f63-b7b9559e6374.png

These issues must be fixed first, before a merge is possible.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/3#pullrequestreview-404142063, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F35ZO34YZS7VTBHZZZTRPLAE7ANCNFSM4MWOOMEQ .

IgorTheLight commented 4 years ago

There is zero difference between your last build from 1.5.1 and 1.5.2 from moddb. So you just forgot to update README.md file! I see now!

On Fri, May 1, 2020 at 5:01 PM Igor Sandu igorthelight@gmail.com wrote:

Thanks for reply. HDPI is hard to tweak: when it looks good with 100% - it looks weird on 100%+. And vise versa. I thing it will be a smarter idea to do this step by step (instead what I did). So I will do that is a few steps:

  • Fork your repository
  • Implement 1.5.2 from moddb
  • Make a pull request to your master branch
  • If you accept it - I will try to do some small tweaks.
  • Make a pull request to your master branch with those small tweaks
  • If you'll like it - I will try to make it DPI independent. I have a small question: why your last version is 1.5.1 when I can find a 1.5.2 here https://www.moddb.com/mods/ultimate-apocalypse-mod/downloads Was it not created by you? Or you just forgot to update it on GitHub? Thanks.

On Fri, May 1, 2020 at 3:47 PM Dennis S. notifications@github.com wrote:

@Fragjacker requested changes on this pull request.

The normal Mod window has some issues with the labels for the windows as they appear in the wrong place when the window is maximized.

[image: image] https://user-images.githubusercontent.com/19975052/80806200-4c63ac80-8bba-11ea-8353-1bd543496637.png

The Mod Merger UI is busted as well as important UI elements are suddenly gone. Below image shows the Mod Merger from your pull and the right is the one from my old v1.52 as how it should look like.

[image: image] https://user-images.githubusercontent.com/19975052/80806008-c8a9c000-8bb9-11ea-9f63-b7b9559e6374.png

These issues must be fixed first, before a merge is possible.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/3#pullrequestreview-404142063, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F35ZO34YZS7VTBHZZZTRPLAE7ANCNFSM4MWOOMEQ .

Fragjacker commented 4 years ago

@IgorTheLight Yes I have forgot to do several updates on my repo my, bad :( The latest version is also not yet merged to the master branch as well. It's located on the v1.5 branch. I really should merge it into master and do the necessary edits to the README.md file!

Fragjacker commented 4 years ago

@IgorTheLight Updated the master branch with the latest stuff just now!

IgorTheLight commented 4 years ago

You also added a Release so it's more convenient to download an executable if needed. Nice!

Please review my pull request - It's not that broken as my previous :-)

On Fri, May 1, 2020 at 6:31 PM Dennis S. notifications@github.com wrote:

@IgorTheLight https://github.com/IgorTheLight Updated the master branch with the latest stuff just now!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/3#issuecomment-622435092, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F3Z6KC34VTFRZW3GOQLRPLTMDANCNFSM4MWOOMEQ .