Version 1.57 (All resources are now embedded in EXE and all settings are now stored in INI)

IgorTheLight commented 4 years ago

Changelog: 1.57

Optimized code a little bit. Now application uses 200 Kb less RAM
Now all image resources are embedded in EXE 1.56
Fixed a crash when GraphicsConfig.exe couldn't be found
Fixed a crash when Config file has wrong or corrupted entries 1.551
Fixed a bug that prevented config file to be readable in some cases
Renamed a few variables 1.55
More code refactoring
Settings are stored in *.ini file now instead of AppData\Local

Fragjacker commented 4 years ago

Oh that's some nice changes there! Especially like how the images are embedded inside the .exe now. That is something I always wanted to do. How did you achieve this? Via the resource manager?

Also there's a merge conflict with the README.md file again. Make sure you resolve that proper so we can merge it.

IgorTheLight commented 4 years ago

Ah! Problems with README.md. How unoriginal, Mr GitHub! I will fix them :-) So how I embedded images?

In Solution Explorer mark every image as "Embedded Resource" instead of "None"
Now you have to call them in code in a little bit different way (look and you will see how I did that). If you are still confused - that may help: http://www.csharp411.com/embedded-image-resources/

On Mon, May 11, 2020 at 4:11 PM Dennis S. notifications@github.com wrote:

Oh that's some nice changes there! Especially like how the images are embedded inside the .exe now. That is something I always wanted to do. How did you achieve this? Via the resource manager?

Also there's a merge conflict with the README.md file again. Make sure you resolve that proper so we can merge it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/5#issuecomment-626692325, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F35YQWFOENUWZ3KHWHLRQ72P3ANCNFSM4M54D3WA .

IgorTheLight commented 4 years ago

Are you busy? I hope you are ok and just have no time to look at this small project :-)

On Mon, May 11, 2020 at 8:47 PM Igor Sandu igorthelight@gmail.com wrote:

Ah! Problems with README.md. How unoriginal, Mr GitHub! I will fix them :-) So how I embedded images?

In Solution Explorer mark every image as "Embedded Resource" instead of "None"

Now you have to call them in code in a little bit different way (look and you will see how I did that). If you are still confused - that may help: http://www.csharp411.com/embedded-image-resources/

On Mon, May 11, 2020 at 4:11 PM Dennis S. notifications@github.com wrote:

Oh that's some nice changes there! Especially like how the images are embedded inside the .exe now. That is something I always wanted to do. How did you achieve this? Via the resource manager?

Also there's a merge conflict with the README.md file again. Make sure you resolve that proper so we can merge it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/5#issuecomment-626692325, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F35YQWFOENUWZ3KHWHLRQ72P3ANCNFSM4M54D3WA .

Fragjacker commented 4 years ago

Oof yeah I am sorry. I am currently in the finishing phase of my Master Thesis paper and have to divert all my time into it since my due date is the 26.05 and my Profs send me some feedback that I have to take into consideration and rework my paper. 😬

Once I am done with this I'll come back to this 😀

IgorTheLight commented 4 years ago

Oh Ok! Don't bother with that :-) Good luck with studying!

On Thu, May 14, 2020 at 3:57 PM Dennis S. notifications@github.com wrote:

Oof yeah I am sorry. I am currently in the finishing phase of my Master Thesis paper and have to divert all my time into it since my due date is the 26.05 and my Profs send me some feedback that I have to take into consideration and rework my paper. 😬

Once I am done with this I'll come back to this 😀

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/5#issuecomment-628616415, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F34CJQADQAL6OXQE27DRRPTELANCNFSM4M54D3WA .

Fragjacker commented 4 years ago

Alright I am back in business now that I finished my Thesis paper 😁 . Gotta review this today!

Fragjacker commented 4 years ago

Other than this your changes look pretty nice and work pretty well! Once you fixed the above issue @IgorTheLight we should be able to merge this.

IgorTheLight commented 4 years ago

Oh thanks for reply! I'll fix it tomorrow. My refactoring probably goes wrong at some lines :-) I hope your study project went fine!

On Mon, May 25, 2020 at 5:52 PM Dennis S. notifications@github.com wrote:

Other than this your changes look pretty nice and work pretty well! Once you fixed the above issue @IgorTheLight https://github.com/IgorTheLight we should be able to merge this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/5#issuecomment-633608536, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F3ZUSNFE4VN3AVUOZSDRTKA4NANCNFSM4M54D3WA .

IgorTheLight commented 4 years ago

I fixed the problem! Please confirm that it's fine now.

On Mon, May 25, 2020 at 5:52 PM Dennis S. notifications@github.com wrote:

Other than this your changes look pretty nice and work pretty well! Once you fixed the above issue @IgorTheLight https://github.com/IgorTheLight we should be able to merge this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/5#issuecomment-633608536, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F3ZUSNFE4VN3AVUOZSDRTKA4NANCNFSM4M54D3WA .

Fragjacker commented 4 years ago

@IgorTheLight Alright, i'll test it ASAP. BTW I see you wanted to implement Winter Assault support but reverted. What happened? 😀

Another idea could be to add support for Dawn of War Game of the Year edition as in supporting vanilla DoW too.

IgorTheLight commented 4 years ago

True - I'm implementing Winter Assault support. The reason why I reverted the changes is because I want you to accept my pull request (1.57). So as you did just that (thank you btw :-) ) I will continue to develop WA support. Actually - it worked just before I reverted it. About supporting the original version. Well... I probably add it also! Just for "100% complete experience".

On Tue, May 26, 2020 at 5:59 PM Dennis S. notifications@github.com wrote:

@IgorTheLight https://github.com/IgorTheLight Alright, i'll test it ASAP. BTW I see you wanted to implement Winter Assault support but reverted. What happened? 😀

Another idea could be to add support for Dawn of War Game of the Year edition as in supporting vanilla DoW too.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/5#issuecomment-634079901, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F32F7YKLHSCE4N7LZL3RTPKOLANCNFSM4M54D3WA .

IgorTheLight commented 4 years ago

Hi! Winter Assault mod support is working! Original Dawn of War mod support is probably working - I not tested it yet. Mod Manager will ignore original files if Winter Assault is in the same directory (for now). I will improve that in the near future :-) Also I'm preparing new "kinda big" release - 1.60 New features:

Winter Assault mod support - already working
Original mod support - testing
Original and WA LAA patching - working (without any additional work from me)
NEW advanced Start option - High Priority + CPU threads restrictions. It could improve performance on some systems. If not - it's OFF by default so no harm is done :-) More information here: https://www.moddb.com/members/psykotenshi/blogs/how-to-improve-performance-on-dawn-of-war-soulstorm The last thing is not working - options don't want to apply. I'm figuring what's the problem. I will not make new pull request for now - everything is not tested at all so 1.57 must be much more stable. If you are interested I could upload a .NET Core version of DoW Mod Manager. I'm not very pleased by it for now - GUI Designer is buggy, application CAN'T be 32-bit and also it takes more RAM (part of the "64-bit application only" problem). If you are curious - no, I'm not planing to replace .NET Framework for .NET Core - I see no point in that. It's Open Source and cross platform but none of that would benefit our little Mod Manager :-)

On Tue, May 26, 2020 at 9:24 PM Igor Sandu igorthelight@gmail.com wrote:

True - I'm implementing Winter Assault support. The reason why I reverted the changes is because I want you to accept my pull request (1.57). So as you did just that (thank you btw :-) ) I will continue to develop WA support. Actually - it worked just before I reverted it. About supporting the original version. Well... I probably add it also! Just for "100% complete experience".

On Tue, May 26, 2020 at 5:59 PM Dennis S. notifications@github.com wrote:

@IgorTheLight https://github.com/IgorTheLight Alright, i'll test it ASAP. BTW I see you wanted to implement Winter Assault support but reverted. What happened? 😀

Another idea could be to add support for Dawn of War Game of the Year edition as in supporting vanilla DoW too.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/5#issuecomment-634079901, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F32F7YKLHSCE4N7LZL3RTPKOLANCNFSM4M54D3WA .

Fragjacker commented 4 years ago

That's excellent news! Yeah I know psyko tenshi well, he's part of my discord moderators 😁 . Support for Winter Assault and base game is also appreciated.

IgorTheLight commented 4 years ago

I'm glad to hear that! :-) I think I could show my result in a few days. But if you are really bored - you may build project using my last commit. I mean - if you are really bored! Also - do you know someone from Ultimate Apocalypse team? If yes - do they care about new (hopefully not bugged) features?

On Wed, May 27, 2020 at 7:21 PM Dennis S. notifications@github.com wrote:

That's excellent news! Yeah I know psyko tenshi well, he's part of my discord moderators 😁 . Support for Winter Assault and base game is also appreciated.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/5#issuecomment-634778275, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F37LLCP3KDFQS4HVJLTRTU4YZANCNFSM4M54D3WA .

Fragjacker commented 4 years ago

@IgorTheLight I am a former UA team member. You may know me as Cosmocrat from Moddb. This tool is still demanded in the community and any changes appreciated 😀 .

IgorTheLight commented 4 years ago

Wow! That's nice to hear! About my progress - game threads optimizations are working now! For some reason not process affinity, nor process priority of the game couldn't be changed right after it starts. So I have to wait a few seconds after launch to change it. And of course users wouldn't know about that and probably would close Mod Manager after starting a game so I had to use System.Threading to ensure loyalty... I mean... to ensure that process priority and affinity WILL change no matter what :-) Original DoW mods are probably supported but I could find them so... :-) Stable release will be available in a few days.

On Thu, May 28, 2020 at 6:12 PM Dennis S. notifications@github.com wrote:

@IgorTheLight https://github.com/IgorTheLight I am a former UA team member. You may know me as Cosmocrat from Moddb. This tool is still demanded in the community and any changes appreciated 😀 .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Fragjacker/DoW-Mod-Manager/pull/5#issuecomment-635412069, or unsubscribe https://github.com/notifications/unsubscribe-auth/APM5F3ZTVAZDWPRX2FQMCFTRTZ5PNANCNFSM4M54D3WA .

Fragjacker / DoW-Mod-Manager

Version 1.57 (All resources are now embedded in EXE and all settings are now stored in INI) #5