search

Fraunhofer-AISEC / ids-clearing-house-service

This is an implementation of the IDS Clearing House
Apache License 2.0
0 stars 11 forks source link

Invalid json response from ClearingHouseOutputProcessor #7

Closed sebplorenz closed 2 years ago

sebplorenz commented 2 years ago

The ClearingHouseOutputProcessor creates an invalid json when sending an IDS response:

2022-02-03 06:25:31.130 DEBUG 1 --- [tp2074382176-32] d.f.a.i.c.ClearingHouseOutputProcessor   : message: {"@context":{"ids":"https://w3id.org/idsa/core/","idsc":"https://w3id.org/idsa/code/"},"@type":"ids:MessageProcessedNotificationMessage","@id":"https://w3id.org/idsa/autogen/MessageProcessedNotificationMessage/f6996272-3a64-4df2-b5de-28cd47a119c0","ids:modelVersion":"4.0.0","ids:correlationMessage":"https://w3id.org/idsa/autogen/requestMessage/ce82b55c-5803-4406-adcb-69e4bab746c9","ids:issued":"2022-02-03T06:25:30.967757041+00:00","ids:issuerConnector":"http://clearinghouse/","ids:senderAgent":"http://clearinghouse","ids:recipientConnector":["https://provider"],"ids:recipientAgent":["https://provider","ids:securityToken" : { "@type" : "ids:DynamicAttributeToken","@id" : "https://w3id.org/idsa/autogen/dynamicAttributeToken/0bd909dc-cea9-4ac7-9cdf-f464b11624b1","ids:tokenFormat" : { "@id" : "idsc:JWT"},"ids:tokenValue" : "eyJ0eXAiOiJhdCtqd3QiLCJraWQiOiJETjhyMFJUVVJlMlJlMHc4VWFOZGgtdGswOXVTdENIT0JCR3V3c1ltbk9VIiwiYWxnIjoiUlMyNTYifQ.eyJzY29wZSI6Imlkc2M6SURTX0NPTk5FQ1RPUl9BVFRSSUJVVEVTX0FMTCIsImF1ZCI6WyJpZHNjOklEU19DT05ORUNUT1JTX0FMTCJdLCJpc3MiOiJodHRwOi8vZGFwc2Z3IiwibmJmIjoxNjQzODY5NTMxLCJpYXQiOjE2NDM4Njk1MzEsImp0aSI6Ik5qZzRNREl4TVRneU9EUTFNakF6TURnMCIsImV4cCI6MTY0Mzg3MzEzMSwiY2xpZW50X2lkIjoiMjg6RjI6QTk6Njc6RDc6MTc6NUE6RjE6QzI6MzU6Mzc6NUE6OTE6QjA6REI6MTQ6NTA6QzY6RjY6RTU6a2V5aWQ6Mjg6RjI6QTk6Njc6RDc6MTc6NUE6RjE6QzI6MzU6Mzc6NUE6OTE6QjA6REI6MTQ6NTA6QzY6RjY6RTUiLCJzZWN1cml0eVByb2ZpbGUiOiJpZHNjOkJBU0VfU0VDVVJJVFlfUFJPRklMRSIsInJlZmVycmluZ0Nvbm5lY3RvciI6Imh0dHA6Ly9jbGVhcmluZ2hvdXNlLmRlbW8iLCJAdHlwZSI6ImlkczpEYXRQYXlsb2FkIiwiQGNvbnRleHQiOiJodHRwczovL3czaWQub3JnL2lkc2EvY29udGV4dHMvY29udGV4dC5qc29ubGQiLCJ0cmFuc3BvcnRDZXJ0c1NoYTI1NiI6Ijg5MzcxZWUzOGFlYjJjMGE0NjY4YWY0MThhYzY0ZTJjYmUwZTM2ZGEzM2Q0OTZkMGJlMzQxYzEzZGExYTE2M2UiLCJzdWIiOiIyODpGMjpBOTo2NzpENzoxNzo1QTpGMTpDMjozNTozNzo1QTo5MTpCMDpEQjoxNDo1MDpDNjpGNjpFNTprZXlpZDoyODpGMjpBOTo2NzpENzoxNzo1QTpGMTpDMjozNTozNzo1QTo5MTpCMDpEQjoxNDo1MDpDNjpGNjpFNSJ9.YZlgOQWIrCV_Z9e59S9IGag3_ulqTLDjze5fvWWympMr5ucxLNdF8y6u--y58sLcWV4gQc5jBZnG8r80eqBfcvD_VQ4BCrE0ut9MnOenMXIJOZA6K1eMAvswGMTclpqFN3X-M_IHinY4CFOSMexsnooo42wapfeOPX0PTQD9JLRDp-xtp8h5D0vhaNCQfOkpnslgMQBdX_XLB-4o9wWKUWcz89_ZHlBfhjTKg3I0Ha3KLhYWQcg6sGGFs4sBLyFiZIaokK19h6D362Zw6_185g-P7I3eypnK_-Fag99pw9xd4ppl4aPVptYvDfuzSp_jAtvBLaBMRyv0j_KBkNpL0g"}]}

The closing brace for the array is missing. The reason can be found here: https://github.com/Fraunhofer-AISEC/ids-clearing-house-service/blob/6e5f8ecdee5bd8a17f0cc8864a9e92520126cb58/clearing-house-processors/src/main/java/de/fhg/aisec/ids/clearinghouse/ClearingHouseOutputProcessor.java#L162

kragall commented 2 years ago

Fixed in master. Will be part of next release