Free-Code-Camp-Seoul / fcc-seoul-website

FCC Seoul Website
https://fcc-seoul.fly.dev
5 stars 8 forks source link

fix(migrate)!: app router and next-intl #62

Closed GMSoudersJr closed 5 months ago

GMSoudersJr commented 5 months ago

I keep getting what looks like the same error for all pages except home, but the messages do not help. There is one more thing I will try but I wanted to get some advice before I spend more time fixing this.

BREAKING CHANGE

GMSoudersJr commented 5 months ago

I have been going over this for days, but am stuck. I have tried adding a linter for hooks, comparing versions of react and react-dom, moving everything into the app router, I don't know else to do. It is probably something simple that I am not seeing. Yay React!

ivanms1 commented 5 months ago

thanks for taking the time to work on this, I'll take a look today

GMSoudersJr commented 5 months ago

No rush at all. One plus of working on this is that it got me back into running. I had to take time to clear my head after some of this.

ivanms1 commented 5 months ago

I think the problem is the NextSeo component, after removing it the error went away. Probably not compatible with app router, yay On the other hand you could use the now built in metada api hopefully that helps

GMSoudersJr commented 5 months ago

Okay, that figures. I did notice that the title wasn't visible in the browser tab. New inspiration!

GMSoudersJr commented 5 months ago

I apologize for how large this is.

Your suggestion worked like a charm. Those errors are gone and it builds successfully.

I implemented the built-in metadata from next.js. The site seems to have the same functionality it did before. Sharing the link needs to be tested, though.

ivanms1 commented 5 months ago

looking good, just one more thing, I think we can uninstall next-seo

GMSoudersJr commented 5 months ago

it's weird. next-seo was not in my package.json

ivanms1 commented 5 months ago

you removed it already 😄

GMSoudersJr commented 5 months ago

Thanks for taking the time to review it.