FreeUKGen / FreeBMD2

For everything related to FreeBMD2. An updated version of the original FreeBMD genealogy website.
Apache License 2.0
1 stars 0 forks source link

Implement 'report a data problem' #215

Closed PatReynolds closed 1 year ago

PatReynolds commented 4 years ago

Tested 8/4/2020, but did not arrive on github as an issue. Rather than being taken to a 'thank you' page, took me to the refinery page with "thank you for your feedback" at the top: image.png

Captainkirkdawson commented 4 years ago

They never go onto github until reviewed by a system administration to confirm that it is an actual issue. The feedback display has that as a specific action.

Cannot comment on navigation after submission

PatReynolds commented 4 years ago

Thanks, Kirk! So, @Vino-S , just the page you are redirected to needs changing.

Vino-S commented 4 years ago

ready for testing on test2

richpomfret commented 4 years ago

@Vino-S to update TEST3 as our testing environment and we can begin using it as our primary testing environment.

richpomfret commented 4 years ago

@Vino-S has this been updated? Let me know and i'll then test this.

Vino-S commented 4 years ago

@richpomfret updated to test3

DeniseColbert commented 4 years ago

I tested this and saw this screen after submission: image

I think the message is very easily missed.

Also, I noticed in "Contacts" that there is the button to "Convert to issue on Github".

EDIT- A story WAS created, it seems, but on FreeREG board:

image

Also, the message went into my Spam folder:

image

Vino-S commented 4 years ago

Fixed. The issue is now created in BMD2 board.

I haven't made changes for message display. Any suggestions would be helpful

PatReynolds commented 4 years ago

Current system is reached from the search detail page (ie as sytem planned here), and provides detailed instructions (which seem not to be read by some users) - https://www.freebmd.org.uk/cgi/corrections.pl?r=252876913&d=bmd_1593465254 and a form that contains the details from the entry in the detailed results page and provides the user with an opportunity to correct those details in a form.

A suggestion: The 'report a data problem' takes the user to a number of option - each option is based on the user identifying what it is they want to do - and then receiving the information (or the form) rather than having a long text to read: e.g "I want to change something to match what is on the certificate (or family bible or FreeREG, FreeCEN ..." does not go to a form but to an explanation. I have divided the current explanations and form on this spreadsheet https://docs.google.com/spreadsheets/d/1VQt3Fjl1y2eixHsPQVp2gSZ0VEVPZ4xYsisbkLiZ01c/edit?usp=sharing

Please discuss on Slack whether this structure/pathway is what is needed, and on the spreadheet if it is (I have largely used the FreeBMD1 text, with some changes for clarity when seen in isolation and/or adding in 'next step'.

richpomfret commented 4 years ago

Next steps - @DeniseColbert to take a look at FAQ on FR to see what they do and then assess in relation to BMD2.

DeniseColbert commented 3 years ago

Pat is suggesting that "Report a Data Problem" takes the user to a number of options with info rather than a contact form. IIUC this is similar to FreeREG FAQs. If we want to avoid the user having to read a lot of information (there are 17 questions), we perhaps need a contents section with anchors. FreeREG FAQs use a sidebar.

geoffj-FUG commented 3 years ago

Pat Can I look at this after I have everything ready for deployment please? I still have a bit of work to go. Geoff

Captainkirkdawson commented 3 years ago

@geoffj-FUG This story refers to FreeBMD2 not CEN but we should look at it over there as well

PatReynolds commented 3 years ago

Denise to put the 17 questions into groups.

DeniseColbert commented 3 years ago

First draft: image.png

richpomfret commented 3 years ago

Use FR/FC to guide design/User Experience here.

DeniseColbert commented 3 years ago

FreeREG FAQ page looks like this: https://www.freereg.org.uk/cms/help/frequently-asked-questions-researchers

The categories in https://docs.google.com/spreadsheets/d/1VQt3Fjl1y2eixHsPQVp2gSZ0VEVPZ4xYsisbkLiZ01c/edit#gid=942996947&range=A1:E7 would be the items in the side menu.

@PhilipClarke712 you asked Pat about the size of the buttons for this IIUC, but we don't use buttons for this on FreeREG (which we're emulating for consistent aesthetic). Pat asked me to send to you the HTML of the FreeREG FAQ page so that you can take the info from the spreadsheet and create a similar page for FreeBMD2. I'll send the HTML file by email to your freeukgenealogy.org.uk account; let me know if you need anything clarifying.

PatReynolds commented 3 years ago

Hi @Vino-S in designing this page, have you remembered it isn't like the set-up in FreeREG and FreeCEN, but a lower option from a number of reporting (see table Denise put in this issue 27 Jan)

PhilipClarke712 commented 3 years ago

Hi @PatReynolds

I've got "my" html pages and images back on test3, I glad to say. So I can ask a question about your comment above to Vino-S.

I've got a draft html page associated with this issue back on test3. It's probably 75+ % complete but I have not seen it for a few days; and its still unchecked by me. ( It's to be found at https://test3.freebmd.org.uk/cms/help/draft-frequently-asked-questions-researchers ).

The Spreadsheet 1 rows 17 to 25, above, imply a link to an Error Reporting Page and give various texts to put on that page. Is that what Vino-s is designing above, or is the Error Reporting Page referred to in the spreadsheet another html page for me to do?

Finally, ignoring any typos for now (I'll hopefully find and fix them), is the draft html page doing what was expected?

DeniseColbert commented 3 years ago

Snip of updated categories:

image

PhilipClarke712 commented 3 years ago

Hi @DeniseColbert ,

Thanks for the snip, I've updated my draft page were necessary against the table above.

I have one question: in the https://www.freereg.org.uk/cms/help/frequently-asked-questions-researchers page given above as an example, if "your question" is not answered the FreeREG page leads you to https://www.freereg.org.uk/contacts/new

FreeBMD2 test3 does not have an identical page, but the nearest ones seem to be: (if I'm not logged on) Report a Problem, or (if I am logged on) https://test3.freebmd.org.uk/contacts

However, the Report a Problem page appears to be very content-specific, if I'm logged on then my name, session id and other timestamps are recorded in the http address ( such as: https://test3.freebmd.org.uk/feedbacks/new?utf8=%E2%9C%93&feedback_time=2021-04-26+21%3A01%3A44+UTC&session_id=7f983925eef58493c06018481fc1b3b9&user_id=Philip+Clarke&problem_page_url=%2Fcms%2Finformation-for-coordinators&previous_page_url=https%3A%2F%2Ftest3.freebmd.org.uk%2Fcontacts&feedback_type=issue ) , but if I'm not logged in I only get Data Problem Report page (such as: https://test3.freebmd.org.uk/contacts/112640983/report_error?locale=en&query=60872ac4bd30f25017b5c12c ) .

So its no too obvious which page I should call up

DeniseColbert commented 3 years ago

@PhilipClarke712 All good points!

I missed out the first step in the process: e.g. FreeREG

image

You can see that (when not logged in) there is a button above the table to Report an Error. This would take the user to your page that is similar in format to the FreeREG FAQs page, but has the title "Reporting Errors in Transcriptions" (unless there's a better one?) and content as per the spreadsheet. At the top of this page, the user should be able to select the nature of the error (perhaps a 'contents' area that jumps to the relevant part of the page?)

We really want to stress that they should only use the contact form if they are absolutely sure that they have a legitimate correction that we can action.

Hope this helps? Sorry for the confusion!

PhilipClarke712 commented 3 years ago

Hi @DeniseColbert,

Thanks for this info.

I've renamed the page. A 1st draft version is now within the Help page hierarchy at https://test3.freebmd.org.uk/cms/help/draft-reporting-errors-in-transcriptions . I have a bit more work to do before handing it back.

It is done in the new "FAQ" format so there is a side navigation table, but problems are grouped together, as Missing Entry group , Problem with Individual group, Problem with District group, etc, so the navi-table takes you down to the level of a "group of related problems" rather than individual problems. The level of indexing can be increased, if you like, to the level of a question. but then that is going away from the FAQ style to just a page with a navigation panel.

Note: from what what you describe above for FreeBMD2, the direction of flow would be from a button on an Entry Information page to this page. Clinking on the button would need to open this help page in a new tab, so that if, say the advice was to report the problem, the researcher can do it from either the search or the Entry Information page. The html page can't give an on-line form to report the error

AlOneill commented 3 years ago

On the Detail page, I suggest that the link to the help page should be just that — a link — and I agree that it should open in a new tab (with a visible warning, of course!).

Use a button for the action that takes a user to the Data Problem Report page. This should also open in a new tab, so that the user can refer back to the suspect record when filling in the report details.

The trick will be to entice a user into read the info first! It will need a good sentence that includes the link and emphasises the benefits of reading the help page.

PatReynolds commented 3 years ago

@PatReynolds to find an example page.

Vino-S commented 3 years ago

Initial implementation is ready for testing in test3

PatReynolds commented 3 years ago

Thanks Vino, looking good!

A few text changes needed now we know what it will look like. I think the text at the bottom is fine for those instances where submitting a report is what we want, but we might want to be more discouraging with those who shouldn't (perhaps "Yes, I have read the above explanation and understand that there is nothing to correct here, but still wish to submit a report" @AlOneill can you think of a better way of saying that ????

Maybe they all need to start "Please do not use this form to report that..." (if the "error" is such that it no report is needed).

Overall, I think the instructions to submit a report probably need @AlOneill 's eye on them. Perhaps "please tick the box below and fill in the form which drops down beneath it"?

"the entry does not match what I know" - needs space Postems(notes) and everywhere Postems are mentioned for the first time it needs "(notes)" after it Also needs "Please also see information on why the month may be "wrong" with link to Help page

"The month/quarter is wrong" - needs link to help page

"see here for help on finding a missing spouse". needs link to help page

"There are characters ...." start "If you have a legible copy ...." as a new paragraph

Suggested text for "I have checked the scan ...." Thank you for checking the scan. Please [standard instructions to fill in the report ]."

AlOneill commented 3 years ago

I have concentrated on errors (grammatical and similar). Some of the text is formal and unfriendly but perhaps that is the aim?!?

Explanation 'i' button — suggest: Please read the explanation below for the selected query

A 0, list-item 2, space missing — Postems (notes) A 0, last para, link-text, space missing and 'link' is superfluous — GRO (opens in new tab)

A 1, wrong use of 'may' and others — You could use a Postem (note) to provide the information which could help other family historians

A 6, hyphen used instead of em-dash — … a spouse search &mdash; see <a href="/cms/help#findSpouse">finding a missing spouse</a> for help

A 8, second part of answer not clear (to me!)

A 9, link missing target="_blank" and link-text missing warning — GRO website (opens in new tab)

A 11, hyphen used instead of em-dash — … a transcription error &mdash; if this is the case, …

A 12, missing text? — please tick the 'Yes, I have read the explanation …' box below and use the form beneath it to give us the details

A 13, list-item 2, same issue with missing space as in A 0 A 13, same issue with link to GRO as in A 0

Q 14, missing word after "spouse's", maybe "first name" or "surname"? A 14, list-item 2, same issue of missing space as in A 0 A 14, same issue with link to GRO as in A 0 A 14, opening para, "provide" rather than "provided" — However, we provide a number of …

Q 15, "the transcription does not match what has been transcribed" cannot be correct! Suggest: the transcription does not match what is on the scan

Tick-box — suggest: Yes, I have read the explanation above but I still wish to submit an error report

In addition, the form id and for label-input pairs do not match.

Link needed to month/quarter info as per Pat's request above: /cms/help#gtkResults

AlOneill commented 3 years ago

There are a lot of twiddly edits to make here: It occurs to me that it might be easier if I edit the partial — just point me to the file.

Vino-S commented 3 years ago

Hi @AlOneill Below is the link to the Frequently asked questions HTML file: https://github.com/FreeUKGen/MyopicVicar/blob/page_entries/public_site_specific/freebmd/faq.html.erb Thank you very much for sorting this out.

AlOneill commented 3 years ago

@Vino-S File edited and returned to you. Of course, that file does not include the 'Explanation' info button text or the label for the tick-box that reveals the form: see my previous comments, three posts above.

15th query — I've attempted to fill in the missing word after "spouse's", but have to admit that it was a shot in the dark! Anyone know what should go there?

@PatReynolds I did not add a link to Help for month/quarter issues as, on reflection, I do not think that Help adds anything material to the explanation given.

PhilipClarke712 commented 3 years ago

Try the original page https://www.freebmd.org.uk/search-results-help.html from FreeBMD1

AlOneill commented 3 years ago

On further reflection, I'm not at all happy about the 15th query, currently: "The entry for this event (for example, bride's surname at marriage) does not match the FreeBMD entry for another person at this event (for example, the spelling of her name in spouse's)."

Unless we can rewrite this to make sense, I suggest we delete it. The previous query seems to cover a similar territory? There is nothing like it (as far as I can see) on the page you gave @PhilipClarke712

PhilipClarke712 commented 3 years ago

@AlOneill Sometime before I started (so pre-Feb. 2020) each item on the BMD1 FAQ page was marked as one of three classes: for About, for Help, or not for Researchers. So the Help-aspects of the original BMD1 FAQ page became a list of less than 41 items -possibly about 22 (at most) FAQs.

It looks like one or more people might have done a brain-storming session on the pared-down BMD1 FAQ Help questions. But, I agree what is written for 14th FAQ does not make any sense.

Note: Michael W Foster wrote two books on the GRO (A comedy of errors is the main title of both volumes), he is believed to be the only non-employee who was allowed to do original research on their registers (registers and indexes) inside Southport. He gives examples where he believes that the vicar (against the rules and regulations) may have filled in the register before the marriage took place, so the bride or groom's signature does not agree with their name as printed on the register. So, this might account for a two entries in the Index. He gave (I think) a few examples were the name of the one the witnesses got entered as bride or groom; and the bride/ groom got entered as a witness. Brides (not applicable to me) would sign their maiden names, not the name of the husband they have just married; but, obviously, if she had been married before her surname would not be the same as her father's surname.

Perhaps, someone brain storming - not me - half remembered these errors and mis-transcribed them.

AlOneill commented 3 years ago

@PhilipClarke712 The queries for the (app) 'Data problem report' page appear to be from the same source as the Refinery page: https://test3.freebmd.org.uk/cms/help-superseded-or-draft/draft-reporting-errors-in-transcriptions#individuals See the 2nd entry.

You make an interesting observation above. Anyone want to have a go at re-wording the query (in the light of Philip's comment above, maybe)? Or do we delete it? Or try to find the original version?

@Vino-S What is the source of the GitHub page — do you know?

[edited]

PatReynolds commented 3 years ago

The word that was escaping me was "accordion"

Example: https://www.all-clad.com/customer-service

Their contact page https://www.all-clad.com/contact is also good at sorting out queries to the right point / collecting the right data

Another (simpler) example https://www.triodos.co.uk/individual (the "why bank with Triodos" section

Many firms are now going to block style with images and a very friendly tone, e.g. https://www.travelperk.com/resources/

https://www.berryinsurance.com/insurance-resources is a completely different approach

richpomfret commented 3 years ago

@AlOneill to have a play. @PatReynolds to create story to turn the form into an accordian style. We need basic functionality for MVP and accordian for future version/iteration.

PatReynolds commented 3 years ago

Original text may be https://www.freebmd.org.uk/search-results-help.html

AlOneill commented 3 years ago

@PatReynolds Sadly, not that file. Thank you for looking.

richpomfret commented 3 years ago

@Vino-S to update the text, also to consider user cases/situations we either provide text for or do not, then we can close this.

richpomfret commented 3 years ago

@PatReynolds to contact Allan about reporting a data problem (to review whether there is a pathway already for this).

PhilipClarke712 commented 3 years ago

If / when someone uses the Entry Information page on FreeBMD(1) to report a problem with a transcription that I (and that applies to other transcribers) transcribed, then my Syndicate Leader, I, or someone else, will be made aware that a change has been requested.

Statistics can be found daily at https://www.freebmd.org.uk/cgi/correction-statistics.pl and the correction is managed at https://www.freebmd.org.uk/cgi/show-corrections.pl (which needs a valid log-on)

As records may be double-keyed that pathway has to determine which syndicate / transcriber should be made responsible for considering / actioning the change request.

I am not familiar with the pathway from Entry Information page to the correction system, but Allan and Barry will be. It replaced a live person and his own spreadsheets.

@PatReynolds My oldest correction goes back to 26/03/2014. I think it took two years to implement the new system. The late Kevin Howell was the Corrections Coordinator with the spreadsheet. Dave Mayall, on behalf of the trustees, reported his death. Something to consider for the News page.

I'm pleased to note that someone did record the introduction of the corrections system on https://test3.freebmd.org.uk/cms/about/history : in came into being in June 2015 - in half the time that I thought it took.

PatReynolds commented 3 years ago

Asked Allan who we should liaise with 17 Aug 2021

PatReynolds commented 3 years ago

Hi @Vino-S - pleaes could you contact Allan and Barrie for details of the system.

DeniseColbert commented 3 years ago

I'll create a new story for page issues, as I don't want to derail this thread

richpomfret commented 3 years ago

@Vino-S to now hook this up.

Vino-S commented 3 years ago

Implementation of a form will be required in my opinion. The form fields will be similar to that of the search form. The form fields will require validations for example Mother's name start quarter.

PhilipClarke712 commented 3 years ago

Or possibly two forms, depending on the request: (1) if an entry is missing then every applicable field (see below) will need to be inputted into a blank form; (2) but, if only one or two fields are wrong (say a typo in a Registration District), as I potential user I might like to have two forms side-by-side, one showing the current data and then other form being the one where I make a correction to one or more fields - (which is how is it is done on BMD(1)).

Mother's name is only provided in the GRO Index from the second Qtr of 1911, so I assume if the systems needs a validation check to done to stop the addition of the Mother's name prior to that quarter. Fair enough; but is the only one of the validation check that is needed.

For example a possibly tricky one to handle is where the GRO index states the mother's / spouse's name was (say) 'Smith or Jones', then FreeBMD transcribers would record that as two separate entries one with the mother / spouse as Smith and one with the mother / spouse as Jones. With a (hash)COMMENT(2) line of explanation between the two entries. So, if I only found only one mother / spouse was indexed, (say) Smith, I could raise a 'data problem' which strictly is the addition of a second entry with the mother's / spouse's name Jones; not to change the original entry from Smith to Smith or Jones ; and the system creates the two (hash)COMMENTs - one attached to each entry. That I assume is a simple programming task to check that the requested change is compliant.

PatReynolds commented 3 years ago

@PhilipClarke712 are you saying that if I enter "The mother's surname is wrong! This is me, and my mother was Susan Jones!!!!" the system will automatically say "The entry is Smith or Jones, and can be found as you can see in the image, and can be found by searching for both Smith and Jones, so no correction is needed".