search

FrendsPlatform / FrendsTemplates

0 stars 0 forks source link

Generic Order file to Salesforce #76

Closed FrendsSarlinS closed 3 months ago

FrendsSarlinS commented 4 months ago

59

jannejjj commented 4 months ago

  1. In the first exclusive decision of the process, where it is checked whether or not the input server address is empty, we should use String.IsNullOrEmpty(#var.InServerAddress) instead of #var.InServerAddress == null, since at least in my tests, the result was false and the process was trying to get the input file from the SFTP server, even with an empty adress.

  2. In the exclusive decision where we check if the SFTP file was read succesfully, string is written with a lowercase s - it should be uppercase :D

  3. From inside the for-loops, we could use intermediate returns instead of throwing errors, so that the whole process doesn't stop if there is an error inside one of the iterations

FrendsSarlinS commented 4 months ago

Thanks for the comment, jannejjj! Changes were made according to your points in the comment.