search

FriendsOfFlarum / pretty-mail

A Flarum extension that allows you to make custom html templates for emails!
MIT License
8 stars 1 forks source link

Beta14 compatability #10

Closed karaok491 closed 4 years ago

karaok491 commented 4 years ago

The release notes should add that the use of app()->url() is not longer supported. Was previously used in the provided sample templates, so likely to cause some issues to users.

The use of $baseUrl should be strongly discouraged, in favour of using the UrlGenerator

For each template that is used uncustomized, 'revert to default' should be clicked on each one, to update the db settings default. We won't want to do this automatically, else we will overwrite some custom templates in the process.

Default templates updated to use $url examples, plus also some minor tweaks

dsevillamartin commented 4 years ago

For each template that is used uncustomized, 'revert to default' should be clicked on each one, to update the db settings default. We won't want to do this automatically, else we will overwrite some custom templates in the process.

We might want to add an alert if $baseUrl is detected in any of the templates.

karaok491 commented 4 years ago

Good shout. Added:

image