FriendsOfFlarum / pretty-mail

A Flarum extension that allows you to make custom html templates for emails!
MIT License
8 stars 1 forks source link

beta 16 - Laravel 8 fix #14

Closed eddiewebb closed 3 years ago

eddiewebb commented 3 years ago

Fixes #12 for Beta 16

Changes proposed in this pull request: Instead of implementing mailer ourselves, this change updates to use Laravel 8.x mailmanager, and get a modified mailer instance from it.

Reviewers should focus on: THere was previously a custom fof Mailer.php that extended laravel's Mailer. Please confirm we're properly registering that instance in the manager to return later.

Screenshot

Screen Shot 2021-04-14 at 2 43 32 PM

Confirmed

hmm

 composer test

  [Symfony\Component\Console\Exception\CommandNotFoundException]  
  Command "test" is not defined. 
imorland commented 3 years ago

Thank you very much for this @eddiewebb 👍

I'll review this later today/tomorrow, I'll come back to you if I have any questions!