search

FriendsOfFlarum / upload

The file upload extension with insane intelligence for your Flarum forum.
https://discuss.flarum.org/d/4154
MIT License
177 stars 96 forks source link

Enable S3 compatible storage #238

Closed AndreasSko closed 3 years ago

AndreasSko commented 4 years ago

Adding endpoint, use_path_style_endpoint, and ACL to the S3 settings (titled as "advanced"). This allows to use S3 compatible storage like Backblaze B2 (solving https://github.com/FriendsOfFlarum/upload/issues/164).

The AWS SDK for PHP sets the ACL to private as default, which some providers don't support if the bucket policy is set to something else. Therefore the awsS3ACL setting allows to tweak that.

I tested the change with AWS S3 and Backblaze B2. I'm open for suggestions and comments 😊

clarkwinkelmann commented 3 years ago

Sorry for the delay. I'm hoping to try out the PR the coming week and I can take care of the merge at this time.

Or if someone else from FoF wants to beat me to it, feel free...

imorland commented 3 years ago

Sorry if this jumps the gun, but I needed S3 alt for a project, so based a new PR (#251 ) and merged.

Thank you for your efforts @AndreasSko