Unlike other extensions which broke other extension's namespace, using loadViewsFrom seems to be actually fine (because it uses afterResolving on the view binding behind the scenes). I tested various load orders with other extensions and could not trigger any error.
We still want to move to Flarum's Extend\View extender to use the public Flarum API and not give a wrong example.
imorland
commented
3 years ago
Upload is currently loading views using
ServiceProvider::loadViewsFrom()https://github.com/FriendsOfFlarum/upload/blob/d9fc9db13e1ece28a75fd79dfcdbba76a78341aa/src/Providers/DownloadProvider.php#L22
Unlike other extensions which broke other extension's namespace, using
loadViewsFromseems to be actually fine (because it usesafterResolvingon theviewbinding behind the scenes). I tested various load orders with other extensions and could not trigger any error.We still want to move to Flarum's
Extend\Viewextender to use the public Flarum API and not give a wrong example.