FriendsOfFlarum / upload

The file upload extension with insane intelligence for your Flarum forum.
https://discuss.flarum.org/d/4154
MIT License
176 stars 95 forks source link

Replace image preview template with markdown #268

Closed askvortsov1 closed 2 years ago

askvortsov1 commented 3 years ago

If it's just an image, using markdown would be simpler, better for editing after the fact, and would interface with the WYSWYG extension

clarkwinkelmann commented 3 years ago

While I do think it should be an option, the downside of markdown is that we can't use custom CSS to alter how it looks, or have wrapping DIVs for any purpose.

Though depending on the styling we want, maybe it's something we want to apply to all images without regard to whether it was uploaded or externally link, in that case it wouldn't matter and we could directly update the IMG template from TextFormatter.

askvortsov1 commented 3 years ago

I think the templates that do have wrapping divs and stuff are fine to leave as is. Iirc there was one template that's just the image preview, I 2ws referring to that one.

luceos commented 2 years ago

image markdown template exists