Update composer.json - Githubissues

FriendsOfFlarum / upload

The file upload extension with insane intelligence for your Flarum forum.

https://discuss.flarum.org/d/4154

MIT License

176 stars 95 forks source link

Update composer.json #283

Closed StarsRivers closed 3 years ago

StarsRivers commented 3 years ago

Fixes #0000

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Confirmed

[ ] Frontend changes: tested on a local Flarum installation.
[ ] Backend changes: tests are green (run composer test).

Required changes:

[ ] Related Flarum core extension PR's: (Omit this section if irrelevant)

clarkwinkelmann commented 3 years ago

any reason for this change? Please include as much details as possible, even more so when the PR doesn't fix an existing issue.

Since fof/upload is no longer on 0.1.x this doesn't make much sense. Branch aliases are useful if another extension depends on this one and you want to work on both master branches at the same time in the same environment. But why would other extensions depend on its 0.1.x version since we are now at 0.14?

luceos commented 3 years ago

This is not necessary. As the versioning of this extension bumps majors quite regularly introducing the branch alias in the composer.json will cause issues for anyone using a constraint like that.