FriendsOfFlarum / upload

The file upload extension with insane intelligence for your Flarum forum.
https://discuss.flarum.org/d/4154
MIT License
175 stars 94 forks source link

Support AWS instance profile S3 credentials #309

Closed grimmdude closed 2 years ago

grimmdude commented 2 years ago

Changes proposed in this pull request:

Let Aws\S3\S3Client attempt to use credentials in instance profile if key and secret are left blank.

Laravel does this currently in Illuminate\Filesystem\FilesystemManager

Reviewers should focus on:

Screenshot

Screen Shot 2022-01-27 at 9 49 29 AM

Confirmed

clarkwinkelmann commented 2 years ago

I had to manually merge the PR to fix conflicts, and since I squashed it GitHub is unable to mark the PR as merged. I'll close the PR now, the squash merge is properly merged on master.