Closed grimmdude closed 2 years ago
Changes proposed in this pull request:
Let Aws\S3\S3Client attempt to use credentials in instance profile if key and secret are left blank.
Aws\S3\S3Client
key
secret
Laravel does this currently in Illuminate\Filesystem\FilesystemManager
Illuminate\Filesystem\FilesystemManager
Reviewers should focus on:
Screenshot
Confirmed
composer test
I had to manually merge the PR to fix conflicts, and since I squashed it GitHub is unable to mark the PR as merged. I'll close the PR now, the squash merge is properly merged on master.
Changes proposed in this pull request:
Let
Aws\S3\S3Client
attempt to use credentials in instance profile ifkey
andsecret
are left blank.Laravel does this currently in
Illuminate\Filesystem\FilesystemManager
Reviewers should focus on:
key
andsecret
are left blank, thenAws\S3\S3Client
should attempt to use credentials in instance profile.Screenshot
Confirmed
composer test
).