In cases where AWS configuration is done on server/env the S3 driver should still be instantiable.
Fixes #0000
Changes proposed in this pull request:
Update src/Adapters/Manager.php to not return null when the DB S3 key is not set. This is because the aws-sdk falls back on $_ENV and system configuration (~/.aws/config) for initialization for added security.
Reviewers should focus on:
It appears this method was already set up to do so, but was later updated to return early.
Screenshot
n/a
Confirmed
[ ] Frontend changes: tested on a local Flarum installation.
[ ] Backend changes: tests are green (run composer test).
In cases where AWS configuration is done on server/env the S3 driver should still be instantiable.
Fixes #0000
Changes proposed in this pull request: Update src/Adapters/Manager.php to not return null when the DB S3 key is not set. This is because the aws-sdk falls back on $_ENV and system configuration (~/.aws/config) for initialization for added security.
Reviewers should focus on: It appears this method was already set up to do so, but was later updated to return early.
Screenshot n/a
Confirmed
composer test).Required changes: