Enable watermark images, uploader is not placed the processed image to the editor's content

FriendsOfFlarum / upload

The file upload extension with insane intelligence for your Flarum forum.

https://discuss.flarum.org/d/4154

MIT License

176 stars 96 forks source link

Enable watermark images, uploader is not placed the processed image to the editor's content #385

Closed hiepvq closed 2 months ago

hiepvq commented 9 months ago

Bug Report

I see the image is processed with watermark but it doesn't place image tothe editor's content immediately.

This bug is an error js code Screenshot 2023-12-16 215113

Screenshot 2023-12-16 215304

i have not tried on local storage yet. I am using S3 storage.

Environment

Flarum core: 1.8.3
PHP version: 8.1.26
Upload version: Checkout code from master

imorland commented 9 months ago

What is emojifiedContentHtml and where does that come from? At first glance this appears to be an issue stemming from another extension

hiepvq commented 9 months ago

No, it still works when i disabled watermark

clarkwinkelmann commented 9 months ago

What is emojifiedContentHtml and where does that come from?

@imorland it's the core emoji extension :wink:

https://github.com/flarum/framework/blob/v1.8.3/extensions/emoji/js/src/forum/renderEmoji.js#L46

github-actions[bot] commented 2 months ago

This issue has been automatically closed because it received no activity for three months. If you think it was closed by accident, please leave a comment. If you are running into a similar issue on the latest version, please open a new issue. Thank you.