search

FriendsOfFlarum / upload

The file upload extension with insane intelligence for your Flarum forum.
https://discuss.flarum.org/d/4154
MIT License
175 stars 94 forks source link

Update FormatTextPreview.php #396

Open edgeinfinity1 opened 4 months ago

edgeinfinity1 commented 4 months ago

Fixes #0000

Changes proposed in this pull request: Fixes the "expand" button's misbehavior while using Text Preview.

Confirmed

Required changes:

DavideIadeluca commented 4 months ago

Hi @edgeinfinity1 thanks for your contribution! Please provide steps to reproduce the issue, and maybe add some screenshots/screencasts before and after the change. Thanks!

edgeinfinity1 commented 3 months ago

Hi @edgeinfinity1 thanks for your contribution! Please provide steps to reproduce the issue, and maybe add some screenshots/screencasts before and after the change. Thanks!

I'm sorry for not being able to provide screenshots before the change, because my forum is already in production state. It's very easy to reproduce the problem:

  1. use "Text Preview" for mime text files.
  2. upload a file within 5 lines, and the expand button shows and does nothing.
  3. upload a file more than 5 lines, and there is no expand button at all.

this problem is obviously because of a misjudgement in rather the file should be expandable, or say just reversed.