FriendsOfGalaxy / galaxy-integration-steam

Integration with Steam for Galaxy
371 stars 77 forks source link

Newly unlocked achievements do not sync #117

Open sven-coppers opened 3 years ago

sven-coppers commented 3 years ago

Describe the bug When I unlock a new achievement, it does not sync to galaxy

To Reproduce

  1. Install the plugin, all achievements sync
  2. unlock a new steam achievement (e.g. surge protector in the screenshot)
  3. The plugin will never show that the new achievement is unlocked

This issue started to occur with version 0.58. I Reverted to 0.57 + my fix and that fixes the issue :(

Expected behavior The newly unlocked achievement would sync automatically, or at least when I click 'sync integrations'. I checked and this behavior still works for the Origin plugin, so it must be an issue with the steam plugin.

Attached logs logs.zip control-achievevements.png

FriendsOfGalaxy commented 3 years ago

Hi @Tauron93 when exactly did you unlock the achievement? I'm asking because the log shows time frame of 2021-05-04 19:57-19:59 so ~ 2 last minutes of working plugin.

If you have logs that are old enough - please search though it to check if Steam send us something.

I doubt that we've introduced a bug in 0.58. I think it's rather old problem or some kind of lag info from Steam. But please double check.

sven-coppers commented 3 years ago

I unlocked the achievement days ago, way before these logs. Instead, I have attached the logs when I click 'sync integrations'.

2021-05-04 19:56:59,814 - plugin - INFO - Asked for achievs for 870780
2021-05-04 19:56:59,814 - galaxy.api.jsonrpc - INFO - Sending notification: method=game_achievements_import_success, params={'game_id': '870780', 'unlocked_achievements': []}

When I reverted to 0.57 + my fix and clicked the same 'sync integrations' button, 'unlocked_achievements' was nog longer empty and the achievement indeed showed up in galaxy.

2021-05-05 19:51:41,461 - plugin - INFO - Asked for achievs for 870780
2021-05-05 19:51:41,461 - galaxy.api.jsonrpc - INFO - Sending notification: method=game_achievements_import_success, params={'game_id': '870780', 'unlocked_achievements': [Achievement(unlock_time=1613588997, achievement_id=None, achievement_name='Choose to be Chosen'), Achievement(unlock_time=1617391843, achievement_id=None, achievement_name='Altered Manifestations May Occur'), Achievement(unlock_time=1615733576, achievement_id=None, achievement_name='Astral Phenomena'), Achievement(unlock_time=1613591489, achievement_id=None, achievement_name='Welcome to the Oldest House'), Achievement(unlock_time=1613846760, achievement_id=None, achievement_name='Unknown Caller'), Achievement(unlock_time=1613932870, achievement_id=None, achievement_name='Directorial Override'), Achievement(unlock_time=1615045361, achievement_id=None, achievement_name="Old Boys' Club"), Achievement(unlock_time=1615134687, achievement_id=None, achievement_name='Threshold'), Achievement(unlock_time=1615721141, achievement_id=None, achievement_name="My Brother's Keeper"), Achievement(unlock_time=1616789675, achievement_id=None, achievement_name='The Face of the Enemy'), Achievement(unlock_time=1616956905, achievement_id=None, achievement_name='Finnish Tango'), Achievement(unlock_time=1617219110, achievement_id=None, achievement_name='Polaris'), Achievement(unlock_time=1617300889, achievement_id=None, achievement_name='Take Control'), Achievement(unlock_time=1613673786, achievement_id=None, achievement_name='Paranatural Powerhouse'), Achievement(unlock_time=1614622823, achievement_id=None, achievement_name='Insular Telekinesis'), Achievement(unlock_time=1613847909, achievement_id=None, achievement_name='Shifting Positions'), Achievement(unlock_time=1615633588, achievement_id=None, achievement_name='Psychic Occupation'), Achievement(unlock_time=1615720512, achievement_id=None, achievement_name='Rising Thought'), Achievement(unlock_time=1618663652, achievement_id=None, achievement_name='Star Performance'), Achievement(unlock_time=1618661916, achievement_id=None, achievement_name='Astral Plumbing'), Achievement(unlock_time=1619720680, achievement_id=None, achievement_name='Familiar Methodologies'), Achievement(unlock_time=1615044094, achievement_id=None, achievement_name='Astral Construction'), Achievement(unlock_time=1616949029, achievement_id=None, achievement_name='Non-Standard Issue'), Achievement(unlock_time=1615716962, achievement_id=None, achievement_name='Career Development'), Achievement(unlock_time=1615633590, achievement_id=None, achievement_name='The Importance of Synergy'), Achievement(unlock_time=1618245659, achievement_id=None, achievement_name='Inter-Departmental Cooperation'), Achievement(unlock_time=1619338692, achievement_id=None, achievement_name='FBC Crisis Solution Task Force'), Achievement(unlock_time=1615718711, achievement_id=None, achievement_name='Paranatural Collection'), Achievement(unlock_time=1618942639, achievement_id=None, achievement_name='Interdimensional Defender'), Achievement(unlock_time=1615043933, achievement_id=None, achievement_name='Parautilitarian'), Achievement(unlock_time=1617302420, achievement_id=None, achievement_name='Expert Parautilitarian'), Achievement(unlock_time=1613849125, achievement_id=None, achievement_name='Ritualistic Thinking'), Achievement(unlock_time=1614709298, achievement_id=None, achievement_name='Ritual Intuition'), Achievement(unlock_time=1617215161, achievement_id=None, achievement_name='Discerning the Pattern'), Achievement(unlock_time=1613674751, achievement_id=None, achievement_name='Strange Collection'), Achievement(unlock_time=1614623696, achievement_id=None, achievement_name='Record Keeper'), Achievement(unlock_time=1615720768, achievement_id=None, achievement_name='Bureau Archivist'), Achievement(unlock_time=1615717956, achievement_id=None, achievement_name='Cognitive Intruder'), Achievement(unlock_time=1615133850, achievement_id=None, achievement_name='Unstable Matter'), Achievement(unlock_time=1619340117, achievement_id=None, achievement_name='Volatile Debris'), Achievement(unlock_time=1615044450, achievement_id=None, achievement_name='Proper Handling Procedures'), Achievement(unlock_time=1617303068, achievement_id=None, achievement_name='First On the Scene'), Achievement(unlock_time=1618664902, achievement_id=None, achievement_name='< Make/Unmake >'), Achievement(unlock_time=1618945387, achievement_id=None, achievement_name='Hostile Work Environment'), Achievement(unlock_time=1618661673, achievement_id=None, achievement_name='Supportive Staff'), Achievement(unlock_time=1619456919, achievement_id=None, achievement_name='A Strong Foundation'), Achievement(unlock_time=1619860589, achievement_id=None, achievement_name='Surge Protector'), Achievement(unlock_time=1619457136, achievement_id=None, achievement_name='Multiple Applications')]}
ShaunV2 commented 3 years ago

GOG Galaxy is saying I don't have all achievements for Riddle Joker when I in fact do, I earned the last one back in December 21st, 2020 and GOG Galaxy only shows I have earned 5 out of 21 achievements which the ones it shows I have earned don't make any sense because you can't earn the last one I got without unlocking the rest first. Screenshot (202) No matter how many times I sync integrations it won't pick up I earned all 21 achievements.

ferrazpedro commented 3 years ago

I noticed that whenever I keep Galaxy in Portuguese, some achievements do not load at all. Don't know if it's really related, to be honest.