FriendsOfGalaxy / galaxy-integration-steam

Integration with Steam for Galaxy
373 stars 77 forks source link

Steam achievements and time played (Similar to issues #91 and #92 #151

Open ferograd opened 2 years ago

ferograd commented 2 years ago

Before start

Describe the bug Steam achievements and time played are missing for myself, but I can clearly see my friends achievements and time played in the same game. I've searched this issues thread and there were similar issues to this (Issue #91 and #92) but these two are now marked as closed and fixed. I've checked the fixes in the plugin files and the websockets and the other file are looking the same for me as the ones in the fix. This does not happen with all games, but I have clear examples and can provide screenshots.

Expected behavior I should be able to see my own achievements and time played for all games on the GOG client instead of only a select few

Attached logs Check how to do it properly: Galaxy Client logs.zip Plugin Logs.zip

Apologies in advance, I am new to GitHub and this community in general so please bear with if I am missing anything from my report. I am more than happy to work on this to resolution and help if I can, though coding is not my strong suit

ferograd commented 2 years ago

Bump?

ferograd commented 2 years ago

I think it might be related to this?

2022-07-08 07:56:42,187 - steam_network.protocol.protobuf_client - WARNING - Unrecognized app structure {'appinfo': {'appid': '461070', 'public_only': '1'}} 2022-07-08 07:56:42,188 - steam_network.protocol.protobuf_client - WARNING - Unrecognized app structure {'appinfo': {'appid': '618910', 'public_only': '1'}} 2022-07-08 07:56:42,189 - steam_network.protocol.protobuf_client - WARNING - Unrecognized app structure {'appinfo': {'appid': '508700', 'public_only': '1'}} 2022-07-08 07:56:42,189 - steam_network.protocol.protobuf_client - WARNING - Unrecognized app structure {'appinfo': {'appid': '539210', 'public_only': '1'}} 2022-07-08 07:56:42,190 - steam_network.protocol.protobuf_client - WARNING - Unrecognized app structure {'appinfo': {'appid': '722000', 'public_only': '1'}} 2022-07-08 07:56:42,191 - steam_network.protocol.protobuf_client - WARNING - Unrecognized app structure {'appinfo': {'appid': '811151', 'public_only': '1'}} 2022-07-08 07:56:42,191 - steam_network.protocol.protobuf_client - WARNING - Unrecognized app structure {'appinfo': {'appid': '992510', 'public_only': '1'}} 2022-07-08 07:56:42,192 - steam_network.protocol.protobuf_client - WARNING - Unrecognized app structure {'appinfo': {'appid': '1096380', 'public_only': '1'}} 2022-07-08 07:56:42,193 - steam_network.protocol.protobuf_client - WARNING - Unrecognized app structure {'appinfo': {'appid': '1270610', 'public_only': '1'}} 2022-07-08 07:56:42,193 - steam_network.protocol.protobuf_client - WARNING - Unrecognized app structure {'appinfo': {'appid': '1523540', 'public_only': '1'}} 2022-07-08 07:56:42,199 - steam_network.protocol.protobuf_client - WARNING - Unrecognized app structure {'appinfo': {'appid': '1200560', 'public_only': '1'}} 2022-07-08 07:56:42,199 - steam_network.protocol.protobuf_client - WARNING - Unrecognized app structure {'appinfo': {'appid': '1200561', 'public_only': '1'}} 2022-07-08 07:56:42,199 - steam_network.protocol.protobuf_client - WARNING - Unrecognized app structure {'appinfo': {'appid': '1200562', 'public_only': '1'}} 2022-07-08 07:56:42,200 - steam_network.protocol.protobuf_client - WARNING - Unrecognized app structure {'appinfo': {'appid': '1211760', 'public_only': '1'}} 2022-07-08 07:56:42,200 - steam_network.protocol.protobuf_client - WARNING - Unrecognized app structure {'appinfo': {'appid': '1793660', 'public_only': '1'}}

DirkPitt1 commented 2 years ago

I have similar bug too. Playtime counter works fine for me but achievements import is very inconsistent. Some games show their achievements nearly in real time. Some show some of them instantly, but at some moment get "stuck" and they catch up several days or a week later. Others just don't show anything until they suddenly get updated after a month or two. Sometimes don't get updated at all. Galaxy logs.zip Steam plugin logs.zip

ferograd commented 2 years ago

Mine simply do not update. Monster hunter Rise is one of them

DirkPitt1 commented 2 years ago

There's a chance they will update eventually. Mine were suddenly updated today. Some, like Baldur's Gate EE after more than 5 months since the last partial update. Only Spirit of the North is showing incorrect percentage right now because it seems to have achievement list including some achievement that doesn't exist on steam (probably has been removed at some point).

ferograd commented 2 years ago

I genuinely would like to know why they do not update in the first place and hopefully get a fix.

I've got several games that have not updated for over a year

Krynh commented 1 year ago

I have the issue where it claims I earned achievements several hours before it actually happened. That's when it does sync them. Poor form from CDPR to set this up and then not update the plugins.

ferograd commented 1 year ago

I don't think that CD Project are the ones to create this plugin

Krynh commented 1 year ago

They set up Galaxy to use these plugins so they must have had a hand in creating them. Otherwise why would they exist?

ferograd commented 1 year ago

They set up Galaxy to use these plugins so they must have had a hand in creating them. Otherwise why would they exist?

By that logic all the game mods on sites like Nexus Mods and the likes are created by the game developers and all the chrome extensions are created by google....

Krynh commented 1 year ago

They advertise galaxy as being able to keep track of all your games and explicitly list the steam and ubisoft plugins

ferograd commented 1 year ago

Can we keep this bug report strictly to the bug? Though I must admit, it has been barren for a really long while =/

More than happy to have this discussion with you in DM's

Krynh commented 1 year ago

Any fix for this? Having Galaxy being out of sync with the correct time is annoying.

ferograd commented 1 year ago

I have a feeling that the devs no longer care for this plugin

cderoeck commented 1 year ago

Same problem on my side. Unfortunately I cannot sync my Steam achievements anymore. It was working until 1 year ago and then for no reason it stopped working. Any idea?

Krynh commented 1 year ago

Same problem on my side. Unfortunately I cannot sync my Steam achievements anymore. It was working until 1 year ago and then for no reason it stopped working. Any idea?

Steam achievement sync is gone but there's a fix to keep the game time and library sync. Check https://github.com/FriendsOfGalaxy/galaxy-integration-steam/issues/159#issuecomment-1489032765

ferograd commented 1 year ago

Is there no way to get steam achievements back though? Do we know why it is no longer working and what can be done to fix it?

Krynh commented 1 year ago

Valve changed something on their end. It can be fixed but only if CPDR/GoG actually bother to update the plugin, otherwise that's the only fix

cderoeck commented 1 year ago

Can't we scrap the profile webpage? :D Not a nice way to integrate this but it could work.