FriendsOfShopware / FroshDevelopmentHelper

Helpful development tools
79 stars 15 forks source link

Stopwatch error when trying to deactivate plugin #50

Closed cscheibelhut closed 1 year ago

cscheibelhut commented 1 year ago

PHP Version

8.1

Shopware Version

6.4

Actual behaviour

[Symfony\Component\ErrorHandler\Error\FatalError]                                                              
  Compile Error: Cannot declare class Symfony\Component\Stopwatch\Stopwatch, because the name is already in use

Expected behaviour

plugin deactivated

Steps to Reproduce?

bin/console plugin:deactivate FroshDevelopmentHelper

the error occurs in admin panel also

amenk commented 1 year ago

Does anyone have a clue how exactly this is caused and how it can be fixed? It even seems to happen, when the plugin is added via composer but not installed & activated - during php bin/console plugin:update of other plugins. But actually I am not sure, if in that case the development helper is the culprit :-)

amenk commented 1 year ago

Is maybe the locked psysh version is problem ? There is a 0.11 release of psysh which would not meet the constraint ^0.10 https://github.com/FriendsOfShopware/FroshDevelopmentHelper/blob/f4dec150edf102621174f0c01ec474869059f574/composer.json#L22

amenk commented 1 year ago

@shyim do you have an idea?

shyim commented 1 year ago

I will look into it 😅 . Need my Gitpod first https://github.com/FriendsOfShopware/FroshDevelopmentHelper/commit/7114b02de7c3afc24d669cd2fca71a7f9dd77041 😂

shyim commented 1 year ago

Problem 1

The composer install is even not working 🤔

shyim commented 1 year ago

with shopware-cli is symfony not in vendor anymore

image

Will tag it later after fixing the other issue :)

amenk commented 1 year ago

Awesome, thank you so much