FriendsOfShopware / FroshProfiler

This plugin allows you to profile your Shopware 5 application
MIT License
157 stars 41 forks source link

Problem with emotion widgets (standard theme) and profiler comments #43

Closed cs-mitho closed 7 years ago

cs-mitho commented 7 years ago

In themes/Frontend/Bare/widgets/emotion/index.tpl there's this code:


<section class="emotion--container emotion--column-{$emotionCols} emotion--mode-{$emotionMode} emotion--{$emotion@index}"
                         data-emotion="true"
                         data-gridMode="{$emotionGridMode}"
                         data-fullscreen="{if $emotionFullscreen}true{else}false{/if}"
                         data-columns="{$emotionCols}"
                         data-cellSpacing="{$cellSpacing}"
                         data-cellHeight="{$cellHeight}"
                         data-baseWidth="{$baseWidth}"
                         {block name="widgets/emotion/index/attributes"}{/block}>`

When using comments for block reference, the profiler breaks the html while surrounding the block in the code above with html comments.

It results in broken code:

![shyim_bug](https://cloud.githubusercontent.com/assets/3703637/24154799/76cabe48-0e52-11e7-939d-4765f3f826da.jpg)
shyim commented 7 years ago

Fixed with latest version