search

FriendsOfShopware / FroshProfiler

This plugin allows you to profile your Shopware 5 application
MIT License
157 stars 41 forks source link

y tho? #85

Closed jhofm closed 6 years ago

jhofm commented 6 years ago

?

shyim commented 6 years ago

This package is already provided by shopware. It helps to reduce package size 😉

jhofm commented 6 years ago

i'm currently going more towards a single set of dependencies instead of the whole plugins requiring their own autoloaders with contradicting dependencies whenever they want mess. the problem with that is that this dependency substitution leads to corrupt composer.lock files if the build instance has this plugin but the target hasn't. i spent about an hour today wondering how my builds just broke ^^. just suggesting the implications for "special" users might not be worth the couple of saved kbs of data. ;)

shyim commented 6 years ago

Could you update then also the composer.lock 😄

jhofm commented 6 years ago

not on this device i can't, but i'll rebase this to something more proper tomorrow. ^^

jhofm commented 6 years ago

i changed the commit message to something more sensible. regarding the composer.lock file: i don't see any; am i missing something?