search

Fusion-Power-Plant-Framework / bluemira

Bluemira is an integrated inter-disciplinary design tool for future fusion reactors. It incorporates several modules, some of which rely on other codes, to carry out a range of typical conceptual fusion reactor design activities.
https://bluemira.readthedocs.io/
GNU Lesser General Public License v2.1
59 stars 16 forks source link

Transfer Sankey-diagram methods into the Power Cycle module using Scoped Tags #1249

Open tplobo opened 2 years ago

tplobo commented 2 years ago

Description of issue / requirement to address

Sankey Diagrams (SDs) represent the instantaneous power balance of a system. The power_cycle module should be able to display its results using a SD.

Proposed solution

Methods that build SDs are already implemented in the balance-of-plant module and should be transferred into the power_cycle module. Compatibility with the classes already defined in power_cycle requires defining the structured transfer of power between systems as an additional input.

A possible implementation could be the use of Scoped Tags (vide Gitlab's scoped labels) to describe a hierarchy between power loads / systems / groups. This would allow the added benefit of describing loads as belonging to particular systems or groups and provide the user with an easy way of retrieving particular sets of power loads (e.g. active loads only required by Magnetic systems).

Since SDs are represented for instants in time, drawing methods would require to be applied in "snapshots" ( i.e. for a desired time "t") of a phase/pulse/scenario.

je-cook commented 2 years ago

The sankey diagram stuff is already in bluemira it just needs to be used/updated for the new powercycle module