Made as many units in plasma_physics and fuel_cycle into SI as possible.

OceanNuclear commented 3 months ago

Linked Issues

Closes #2858

Description

Sometimes "years" is used instead of "s" but when in context that's quite reasonable, so I haven't changed those.

Interface Changes

bluemira.fuel_cycle.tools.legal_limit: Now takes in [kg/s] and [W], and returns [kg/yr] (previously takes in: [g/s], [MW] returns: g/yr)
bluemira.fuel_cycle.cycle.calc_m_release: Now returns [kg/yr] (previously g/yr)
bluemira.plasma_physics.E_DT_fusion: now outputs [J] (previously outputs [eV])
bluemira.plasma_physics.E_DD_fusion: now outputs [J] (previously outputs [eV])
bluemira.plasma_physics.n_DT_reactions: now takes in [W] and outputs [1/s] (previously [MW]->[1/s])
bluemira.plasma_physics.n_DD_reactions: now takes in [W] and outputs [1/s] (previously [MW]->[1/s])
bluemira.plasma_physics.r_T_burn: now takes in [W] and outputs [kg/s] (previously [MW]->[g/s])
bluemira.plasma_physics.r_D_burn_DT: now takes in [W] and outputs [kg/s] (previously [MW]->[g/s])

Checklist

I confirm that I have completed the following checks:

[ ] Tests run locally and pass pytest tests --reactor
[ ] Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
[ ] Documentation built locally and checked sphinx-build -W documentation/source documentation/build

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 22.22222% with 14 lines in your changes missing coverage. Please review.

Project coverage is 74.62%. Comparing base (1acb6ec) to head (7585bd8).

Files	Patch %	Lines
bluemira/fuel_cycle/cycle.py	0.00%	5 Missing :warning:
bluemira/plasma_physics/reactions.py	33.33%	4 Missing :warning:
bluemira/fuel_cycle/lifecycle.py	0.00%	2 Missing :warning:
bluemira/fuel_cycle/tools.py	50.00%	2 Missing :warning:
...uemira/radiation_transport/neutronics/constants.py	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #3374 +/- ## =========================================== + Coverage 74.60% 74.62% +0.02% =========================================== Files 242 242 Lines 27006 27003 -3 =========================================== + Hits 20147 20152 +5 + Misses 6859 6851 -8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

⚠️ Warning Report

Found 0 new warnings, 0 fixed warnings. 🎉

All warnings (5)

#### On runtest - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:26: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead` - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:23: DeprecationWarning: Use of elements created by UFL is deprecated. You should create elements directly using Basix.` - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/basix/ufl.py:1909: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead` - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/expr.py:275: DeprecationWarning: Expr.ufl_domain() is deprecated, please use extract_unique_domain(expr) instead.` #### On collect - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/ufl_type.py:56: DeprecationWarning: attach_operators_from_hash_data deprecated, please use UFLObject instead.`