feat: pyclipper -> pyclipr

Fusion-Power-Plant-Framework / bluemira

Bluemira is an integrated inter-disciplinary design tool for future fusion reactors. It incorporates several modules, some of which rely on other codes, to carry out a range of typical conceptual fusion reactor design activities.

https://bluemira.readthedocs.io/

GNU Lesser General Public License v2.1

50 stars 15 forks source link

feat: pyclipper -> pyclipr #3375

Open oliverfunk opened 3 weeks ago

oliverfunk commented 3 weeks ago

Linked Issues

Closes #3197

Description

Moves to the new pyclipr package based on Clipper2 for the fallback offsetting library.

Interface Changes

None, only internal api's.

Checklist

I confirm that I have completed the following checks:

[ ] Tests run locally and pass pytest tests --reactor
[ ] Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
[ ] Documentation built locally and checked sphinx-build -W documentation/source documentation/build

oliverfunk commented 3 weeks ago

3 problems:

Seemingly cannot set Miter limit
The accuracy of the returned offset no longer passes the "isclose" checks unless the precision is reduced
Pclippr does not return None for invalid geometry, it no longer fails, which means one of the tests fails because of it

also: The docs need to be updated Dep needs to be added

je-cook commented 2 weeks ago

Cool! how do you feel about the package, good change?

oliverfunk commented 1 week ago

I've realised after testing, this seemingly cannot do negative offsets.

sonarcloud[bot] commented 1 week ago

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint