Fusion-Power-Plant-Framework / bluemira

Bluemira is an integrated inter-disciplinary design tool for future fusion reactors. It incorporates several modules, some of which rely on other codes, to carry out a range of typical conceptual fusion reactor design activities.
https://bluemira.readthedocs.io/
GNU Lesser General Public License v2.1
50 stars 15 forks source link

🐛 Catch debug folder path doesnt exist #3391

Closed je-cook closed 1 week ago

je-cook commented 2 weeks ago

Description

If bluemira is installed to site-packages this folder wont exist therefore we make one in the cwd if required.

Interface Changes

Checklist

I confirm that I have completed the following checks:

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 81.48148% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.63%. Comparing base (1acb6ec) to head (23934e1). Report is 9 commits behind head on develop.

Files Patch % Lines
bluemira/geometry/tools.py 73.33% 4 Missing :warning:
bluemira/base/logs.py 91.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3391 +/- ## =========================================== + Coverage 74.60% 74.63% +0.03% =========================================== Files 242 230 -12 Lines 27006 26773 -233 =========================================== - Hits 20147 19982 -165 + Misses 6859 6791 -68 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 weeks ago

⚠️ Warning Report

Found 0 new warnings, 0 fixed warnings. 🎉

All warnings (5) #### On runtest - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/basix/ufl.py:1909: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead` - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:23: DeprecationWarning: Use of elements created by UFL is deprecated. You should create elements directly using Basix.` - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/expr.py:275: DeprecationWarning: Expr.ufl_domain() is deprecated, please use extract_unique_domain(expr) instead.` - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:26: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead` #### On collect - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/ufl_type.py:56: DeprecationWarning: attach_operators_from_hash_data deprecated, please use UFLObject instead.`
je-cook commented 2 weeks ago

As discussed changed slightly the serialisation on error behaviour

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud