Fusion-Power-Plant-Framework / bluemira

Bluemira is an integrated inter-disciplinary design tool for future fusion reactors. It incorporates several modules, some of which rely on other codes, to carry out a range of typical conceptual fusion reactor design activities.
https://bluemira.readthedocs.io/
GNU Lesser General Public License v2.1
50 stars 15 forks source link

Add radiation tools tests #3394

Open athoynilimanew opened 2 weeks ago

athoynilimanew commented 2 weeks ago

Linked Issues

Description

Added tests for the following

Interface Changes

Checklist

I confirm that I have completed the following checks:

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.36%. Comparing base (b1cf23b) to head (4dc63b2). Report is 5 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3394 +/- ## =========================================== - Coverage 74.57% 74.36% -0.21% =========================================== Files 231 231 Lines 26810 26810 =========================================== - Hits 19993 19937 -56 - Misses 6817 6873 +56 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 weeks ago

⚠️ Warning Report

Found 0 new warnings, 0 fixed warnings. 🎉

All warnings (5) #### On runtest - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:23: DeprecationWarning: Use of elements created by UFL is deprecated. You should create elements directly using Basix.` - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/basix/ufl.py:1909: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead` - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:26: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead` - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/expr.py:275: DeprecationWarning: Expr.ufl_domain() is deprecated, please use extract_unique_domain(expr) instead.` #### On collect - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/ufl_type.py:56: DeprecationWarning: attach_operators_from_hash_data deprecated, please use UFLObject instead.`
athoynilimanew commented 1 week ago

I agree with @OceanNuclear's comment.

Also this doesnt close #3330, there are some more tests to be written specifically something that calls FirstWallRadiationSolver. It should be a very simple case with only a couple of detectors.

Added test for FirstWallRadiationSolver (but the test requires a bit of time to run)