Closed ym1906 closed 3 months ago
Attention: Patch coverage is 37.50000%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 74.29%. Comparing base (
2a2c8b0
) to head (a2fbe22
). Report is 3 commits behind head on develop.
Files | Patch % | Lines |
---|---|---|
bluemira/codes/_freecadapi.py | 33.33% | 4 Missing :warning: |
bluemira/geometry/tools.py | 50.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Found 0 new warnings, 0 fixed warnings. 🎉
dunno why sonarcloud isnt running...
Closes #3363
Description
As a modeller and reactor designer I want to develop the capability to optimise stellarator designs with Bluemira. This requires the ability to represent the plasma's boundary in CAD form.
The software package Simsopt is widely used to optimise stellarators. Simsopt can generate a 3D plasma surface but this must be translated into a NURBS (Non-uniform rational B Spline) surface for CAD representation within Bluemira.
Solution
Added make_bsplinesurface to geometry tools and free_cad api
Checklist
I confirm that I have completed the following checks:
pytest tests --reactor
pre-commit run --from-ref develop --to-ref HEAD
sphinx-build -W documentation/source documentation/build