Fusion-Power-Plant-Framework / bluemira

Bluemira is an integrated inter-disciplinary design tool for future fusion reactors. It incorporates several modules, some of which rely on other codes, to carry out a range of typical conceptual fusion reactor design activities.
https://bluemira.readthedocs.io/
GNU Lesser General Public License v2.1
50 stars 15 forks source link

🎨 Cleanup radiation transport #3398

Closed je-cook closed 1 week ago

je-cook commented 1 week ago

Description

Does a bit of general housekeeping, no functional changes

Interface Changes

Removed MidPlaneProfiles is now a dataclass returned by the function 'midplane_profiles'. Changed the interface to CoreRadiation to take advantage of not needing to pass in the profiles individually.

Checklist

I confirm that I have completed the following checks:

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 29.57746% with 50 lines in your changes missing coverage. Please review.

Project coverage is 74.57%. Comparing base (2a2c8b0) to head (7afbbb9).

Files Patch % Lines
...adiation_transport/midplane_temperature_density.py 39.53% 26 Missing :warning:
bluemira/radiation_transport/radiation_profile.py 14.81% 23 Missing :warning:
bluemira/radiation_transport/radiation_tools.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3398 +/- ## =========================================== + Coverage 74.51% 74.57% +0.05% =========================================== Files 230 230 Lines 26813 26764 -49 =========================================== - Hits 19979 19958 -21 + Misses 6834 6806 -28 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 week ago

⚠️ Warning Report

Found 0 new warnings, 0 fixed warnings. 🎉

All warnings (5) #### On runtest - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:26: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead` - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/expr.py:275: DeprecationWarning: Expr.ufl_domain() is deprecated, please use extract_unique_domain(expr) instead.` - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:23: DeprecationWarning: Use of elements created by UFL is deprecated. You should create elements directly using Basix.` - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/basix/ufl.py:1909: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead` #### On collect - `/home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/ufl_type.py:56: DeprecationWarning: attach_operators_from_hash_data deprecated, please use UFLObject instead.`