search

Fusion-Power-Plant-Framework / bluemira

Bluemira is an integrated inter-disciplinary design tool for future fusion reactors. It incorporates several modules, some of which rely on other codes, to carry out a range of typical conceptual fusion reactor design activities.
https://bluemira.readthedocs.io/
GNU Lesser General Public License v2.1
50 stars 15 forks source link

Rework sankey diagram test #3415

Closed je-cook closed 2 days ago

je-cook commented 1 week ago

Describe the bug

The Sankey diagram test in balance of plant is a png comparison which can easily fail due to dependency changes.

Steps to reproduce

See #3414 at various stages for the failure and image similarity, I cant see the difference in the file

Expected behaviour

Test doesnt fail so sporadically

Additional context

Possibly moving to an svg would be more robust, alternatively a better test entirely could be created